changes to support correct boolean values for deepEquals#148
Merged
Conversation
nadiapadalka
added
bug
olenahuchko
approved these changes
Apr 6, 2026
| end if | ||
|
|
||
| if __roca_isString(lhs) and __roca_isString(rhs) then | ||
| if _roca_isSameValueType(lhs, rhs) then |
Nowele
reviewed
Apr 10, 2026
| m.it("failure string values", sub() | ||
| argument = "test" | ||
| result = fakeFunc(argument) | ||
| m.assert.deepEquals(result, false, "Expected mock function 'fakeFunc' should have returned 'test', but false is expected") |
Collaborator
There was a problem hiding this comment.
for string, should it return a different string value or false?
Collaborator
Author
There was a problem hiding this comment.
this is test for failure
Nowele
reviewed
Apr 10, 2026
| actual: "test", | ||
| expected: "false", | ||
| message: | ||
| "Expected mock function 'fakeFunc' should have returned 'test', but false is expected", |
Collaborator
Author
There was a problem hiding this comment.
no, this is test for failure
Nowele
approved these changes
Apr 15, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added changes to compare all types in scope of
deepEqualsfunction, added more tests for checking new logic as well