fix: publish workflow recognizes custom PR merge subjects#121
Merged
Conversation
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
The check-release step only matched "Merge pull request ... from .../release/" and "Merge branch 'release/..." patterns. A custom --subject like "Release v0.4.2" was not detected. Add a third pattern that matches commit messages starting with "Release vX" or "Hotfix vX", and fall back to pyproject.toml for the branch name when no release/ path appears in the commit message. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
check-releasestep inpublish.ymlonly matched two commit message patterns:Merge pull request #N from org/release/vX.Y.Z(default GitHub merge)Merge branch 'release/vX.Y.Z'(local merge)--subjectis passed togh pr merge(e.g."Release v0.4.2"), neither pattern matched and publication was skipped with❌ Not a release or hotfix branch merge.Fix
Added two additional patterns to the check:
^Release v?X— matches custom subjects like "Release v0.4.2"^Hotfix v?X— matches custom subjects like "Hotfix v0.4.2"When no
release/path appears in the commit message, the branch name now falls back to reading the version frompyproject.toml(e.g.release/v0.4.2).Test plan
🤖 Generated with Claude Code