Separate, embeddable method comparison space#3303
Conversation
PR huggingface#3300 drafts the idea of embedding the method comparison results into the respective method pages. This calls for a lighter version of the existing space to limit the needed space. This is what `app_embed.py` is. Most of the common processing has moved to the existing and aptly named `processing.py`. I think that this is better than having a layout switch in `app.py` as these apps are meant to be as flat as can be to be readable and maintainable.
|
The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update. |
BenjaminBossan
left a comment
BenjaminBossan
left a comment
There was a problem hiding this comment.
Generally LGTM. I haven't checked every change, as I assume that most stuff was just moved around.
Regarding the pareto plots, I noticed is that the method is not always highlighted, e.g. here:
Is it because it is on the Pareto frontier?
Moreover, e.g. for LoRA, not all LoRA points are highlighted, e.g. here:
It could be the same issue (no highlight if on Pareto frontier) or a different one (rs-LoRA is not considered to be LoRA).
| ) | ||
|
|
||
|
|
||
| metric_preferences = { |
There was a problem hiding this comment.
Is this dict needed? get_metric_preferences should already be doing the job.
|
I assume you tested on https://huggingface.co/spaces/hubnemo/peft-method-comparison-individual - that was running a version before some of the fixes. I've updated the space so you can test there again if you like. Both of these issues are already addressed in the code of the PR. |
3 participants
PR #3300 drafts the idea of embedding the method comparison results into the respective method pages. This calls for a lighter version of the existing space to limit the needed space. This is what
app_embed.pyis.Most of the common processing has moved to the existing and aptly named
processing.py.I think that this is better than having a layout switch in
app.pyas these apps are meant to be as flat as can be to be readable and maintainable.