fix: skip filename-based split detection for media files in get_data_… - #8257
Open
Work4itnow wants to merge 6 commits into
Open
fix: skip filename-based split detection for media files in get_data_…#8257Work4itnow wants to merge 6 commits into
Work4itnow wants to merge 6 commits into
Conversation
ebarkhordar
reviewed
Jul 28, 2026
ebarkhordar
left a comment
Contributor
There was a problem hiding this comment.
MEDIA_EXTENSIONS is missing a comma after ".tif", so Python concatenates that literal with the next one. The set ends up holding ".tif.mp3", and neither ".tif" nor ".mp3" is in it.
At this PR's head (3235cad), in a clean container:
>>> sorted(datasets.data_files.MEDIA_EXTENSIONS)
['.aac', '.avi', '.bmp', '.flac', '.gif', '.jpeg', '.jpg', '.m4a', '.mkv',
'.mov', '.mp4', '.ogg', '.png', '.tif.mp3', '.tiff', '.wav', '.webm', '.webp']
So the original bug survives for those two extensions. Three files in a flat folder, one of them named train.<ext>, resolved with get_data_patterns() then DataFilesDict.from_patterns():
.png ['pika.png', 'pika_pika.png', 'train.png']
.tiff ['pika.tiff', 'pika_pika.tiff', 'train.tiff']
.wav ['pika.wav', 'pika_pika.wav', 'train.wav']
.tif ['train.tif']
.mp3 ['train.mp3']
On main (b305031) all five return only the train.* file, so the fix does work. It just misses .mp3, which is the extension an audio folder is most likely to use. The new test covers .png, so CI stays green either way.
Author
|
Thank you for helping me catch it! I add the missing comma. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #7201
Problem
When a user has an image file named
train.pngin a flat folder,the library mistakenly treats it as a split name instead of an image,
resulting in only that one file being loaded.
Fix
Modified
_get_data_files_patternsindata_files.pyto skipfilename-based split detection when all matched files are media files
(images, audio, video). This causes it to fall through to
DEFAULT_PATTERNS_ALLwhich correctly loads all files.Test
Added
test_data_files_with_image_named_after_splitto verifythat all images are loaded when one is named after a split.