pause on background instead of disconnecting#66
Open
SandiyosDev wants to merge 9 commits into
Open
Conversation
Owner
|
idk if you have noticed but the root cause of disconnecting in background is not OpenParsec actively disconnecting from host, but VideoToolBox failed to decode the frame in the background for some reason. And the error code we get from ParsecSDK is -14 (DECODE_ERR_DECODE). Even with this pr I still get this error with the video stream frozen. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
app kills the parsec connection when you switch apps or lock screen , this pr uses ParsecClientPause to pause and resume video/audio streams
some issues would appear where keys remain pressed even after disconnect, this pr would release all pressed keys on background so key presses doesn't get stuck on the host; gl render loop is also paused so it doesnt crash the app on sleep disconnects
pip controller is now only created when the setting is on (builds on #62), I added a toggle in settings for PiP, I also added toggles for status (top bar) and fixed mute to stop host audio streams instead of muting locally