Andy on 30853

[WilkAndy]

Stacked on idaholab#30853: please merge into neml2_assembly before upstream integration

As advised by @dschwen , this PR is closely tied to the original idaholab#30853 , and i need both for the simulations I'm currently doing, so I'm hoping you can merge my two additions into neml2_assembly before idaholab#30853 goes to idaholab:next.

@hugary1995 - please advise if this isn't what you want. Thanks!

[WilkAndy]

@hugary1995 , i think i misunderstood @dschwen about combining these two MOOSE PRs. He's talking about eating two half-doughnuts at once, or ?!?! Let's leave this till Monday when you can chat with him.

[dschwen]

Very nice PR. Have you checked what the lumped mass matrix tags in other explicit time integrators are?

[WilkAndy]

Very nice PR. Have you checked what the lumped mass matrix tags in other explicit time integrators are?

I just had a look, using moose/framework/src/timeintegrators> find . -name "*.C" | xargs grep "addVector(" and the only relevant thing appeared to be ./ExplicitTimeIntegrator.C: _mass_matrix_diag_inverted(addVector("mass_matrix_diag_inverted", true, GHOSTED)), . The only module to have a timeintegrator is solid_mechanics modules. So it looks like we're the only ones who want a lumped mass matrix in the whole of MOOSE.

[dschwen]

That can't be true. ActuallyExplicitEuler uses mass lumping, but it does not use the tag system (I should update that class...). So maybe ExplicitMixedOrder is the only time integrator that uses a matrix tag for the mass matrix.

[WilkAndy]

That can't be true. ActuallyExplicitEuler uses mass lumping, but it does not use the tag system (I should update that class...). So maybe ExplicitMixedOrder is the only time integrator that uses a matrix tag for the mass matrix.

Aha, i thought you were thinking that the stuff below should be generalised in my ExplicitMassDamping Kernel, to allow other timesteppers to use the Kernel:

 if (nl.hasVector("mass_matrix_lumped"))
    return nl.getVector("mass_matrix_lumped");

[hugary1995]

Uhm, anything I can help with? I am fine merging this.