Skip to content

harbor convert update (superseded)#410

Closed
nancyjlau wants to merge 1 commit into
mainfrom
nancyjlau/harbor-convert-update
Closed

harbor convert update (superseded)#410
nancyjlau wants to merge 1 commit into
mainfrom
nancyjlau/harbor-convert-update

Conversation

@nancyjlau
Copy link
Copy Markdown
Contributor

@nancyjlau nancyjlau commented May 8, 2026

No description provided.

@nancyjlau nancyjlau force-pushed the nancyjlau/harbor-convert-update branch from 08fc1f0 to ea3e57d Compare May 8, 2026 16:48
Co-authored-by: Ryan Tan <63581031+ryantzr1@users.noreply.github.com>
@nancyjlau nancyjlau force-pushed the nancyjlau/harbor-convert-update branch from ea3e57d to 6568d5f Compare May 8, 2026 16:55
@nancyjlau nancyjlau changed the title harbor convert update harbor convert update (superseded) May 8, 2026
@nancyjlau nancyjlau closed this May 8, 2026
@nancyjlau nancyjlau deleted the nancyjlau/harbor-convert-update branch May 8, 2026 16:57
Copy link
Copy Markdown

@cursor cursor Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursor Bugbot has reviewed your changes and found 1 potential issue.

Fix All in Cursor

❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.

Reviewed by Cursor Bugbot for commit 6568d5f. Configure here.

Comment thread hud/cli/convert/harbor.py

slug = base
if slug in used_slugs:
slug = f"{base[:91].rstrip('-')}-{digest}"
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Slug collision resolution is a no-op for long names

Low Severity

In _make_task_slug, when len(base) > 100, line 112 rewrites base to f"{base[:91].rstrip('-')}-{digest}". The subsequent collision check on line 115–116 computes f"{base[:91].rstrip('-')}-{digest}" again, which in the common case (no trailing dashes near position 91) reproduces the same value as base, leaving slug unchanged and the collision unresolved. The while loop on lines 118–123 catches it, so uniqueness is preserved, but the if branch is effectively dead code for truncated slugs.

Fix in Cursor Fix in Web

Reviewed by Cursor Bugbot for commit 6568d5f. Configure here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant