harbor convert update (superseded)#410
Conversation
08fc1f0 to
ea3e57d
Compare
Co-authored-by: Ryan Tan <63581031+ryantzr1@users.noreply.github.com>
ea3e57d to
6568d5f
Compare
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit 6568d5f. Configure here.
|
|
||
| slug = base | ||
| if slug in used_slugs: | ||
| slug = f"{base[:91].rstrip('-')}-{digest}" |
There was a problem hiding this comment.
Slug collision resolution is a no-op for long names
Low Severity
In _make_task_slug, when len(base) > 100, line 112 rewrites base to f"{base[:91].rstrip('-')}-{digest}". The subsequent collision check on line 115–116 computes f"{base[:91].rstrip('-')}-{digest}" again, which in the common case (no trailing dashes near position 91) reproduces the same value as base, leaving slug unchanged and the collision unresolved. The while loop on lines 118–123 catches it, so uniqueness is preserved, but the if branch is effectively dead code for truncated slugs.
Reviewed by Cursor Bugbot for commit 6568d5f. Configure here.


No description provided.