Add lightweight PR review scaffold#830
Conversation
|
Findings: none from this review pass. Open questions / assumptions: I reviewed the current PR head, including the final simplification to a blank five-block template. The docs, fixture, smoke, and implementation now agree that metadata risk is only queue-ordering context and the agent must read the real PR body/diff before filling review content. Validation performed:
Merge decision: hold for normal reviewer/branch-protection flow; no protocol/CLI blocker found in this pass. |
|
Review result: hold / changes needed. GitHub will not let me formally request changes on my own PR, so leaving the review as a PR comment. Findings:
Validation performed:
Merge decision: hold. The implementation is cleanly validated, but it currently regresses the richer PR review contract on main. |
|
Findings: none on the current owner-directed version. Open questions / assumptions: Earlier hold feedback on this PR asked for richer generated risk analysis, but the product direction was later changed explicitly: Validation performed:
Merge decision: self-merge authorized by owner. This is a single-purpose PR review command contract change, public-safe, validated, and not Lark Kanban related. |
|
Admin-bypass merge audit note. Owner explicitly authorized admin-bypass after normal Focused validation rerun immediately before merge:
Scope remains the generic |
Summary
/loopx-pr-reviewinto a lightweight, generic PR review scaffold instead of trying to write the review itself.review_groups.unmergedandreview_groups.mergedso agentloop follows the user's intended open/unmerged vs merged-review flow.agent_contractandloopx-projectskill wording that requires runningloopx pr-reviewfirst; manualghcalls are only for per-PR deep reading after the CLI packet selects a PR.动机、改动思路、具体改动、对主干的风险、我的整体评价.Validation
python3 examples/pr-review-command-smoke.pypython3 examples/slash-command-catalog-smoke.pypython3 examples/bootstrap-command-pack-smoke.pypython3 -m py_compile loopx/pr_review.py loopx/slash_commands.py loopx/cli_commands/pr_review.pygit diff --checkloopx check --scan-path loopx/pr_review.py --scan-path loopx/slash_commands.py --scan-path skills/loopx-project/SKILL.md --scan-path examples/pr-review-command-smoke.py --scan-path examples/slash-command-catalog-smoke.py --scan-path examples/bootstrap-command-pack-smoke.py --scan-path docs/reference/protocols/pr-review-command-v0.mdpython3 -m loopx.cli pr-review --fixture examples/fixtures/pr-review.public.json --limit 5Boundary