fix(macos): add -sender flag to terminal-notifier for banner notifications#48
Open
j-hannes wants to merge 1 commit into
Open
fix(macos): add -sender flag to terminal-notifier for banner notifications#48j-hannes wants to merge 1 commit into
j-hannes wants to merge 1 commit into
Conversation
j-hannes
force-pushed
the
fix/macos-terminal-notifier-sender
branch
from
0bdbae2 to
2b982d6
Compare
…tions On some macOS setups, terminal-notifier's own bundle ID isn't properly registered for notifications, causing notifications to appear only in Notification Center without showing banners. Adding `-sender com.apple.Terminal` borrows Terminal.app's notification permissions, which resolves the issue. This aligns the Claude script with the Copilot script, which already includes this flag.
j-hannes
force-pushed
the
fix/macos-terminal-notifier-sender
branch
from
2b982d6 to
5ecc1c9
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
On some macOS setups,
terminal-notifier's own bundle ID isn't properly registered for notifications, causing notifications to appear only in Notification Center without showing as banners.Adding
-sender com.apple.Terminalborrows Terminal.app's notification permissions, which resolves the issue.Changes
-sender com.apple.Terminalflag to theterminal-notifiercommand inclaude/claude-code-notifier.shNotes
The Copilot script (
copilot/copilot-cli-notifier.sh) already includes this flag (line 135), so this change aligns the two scripts.Testing
Tested on macOS Sequoia (Darwin 25.2.0) where notifications were not displaying as banners before the fix.