chore(ci): bump gocyclo budget 13 → 15#114
Merged
Merged
Conversation
FJB-94 adds one top-level setup branch per phase to cmd/fj-bellows main.run, which kept colliding with the gocyclo=13 budget and forcing extract-a-helper cycles for each phase. 15 still catches genuinely sprawling functions (upstream default is 30) without making every cross-cutting concern an extraction. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
FJB-94 adds one top-level setup branch per phase to
cmd/fj-bellows main.run(token-load → cache deploy → agent.Dialer → eventually FJB-97 / FJB-93 consumers). Each phase keeps colliding with the gocyclo=13 budget and forcing extract-a-helper cycles. That's noise, not signal — the extracted helpers are good for readability but the linter is making me churn through them just to land cross-cutting wiring.Bumping to 15 still catches genuinely sprawling functions (upstream default is 30 — we stay well below) without making every cross-cutting concern a separate refactor. Once the FJB-94 chain lands and the agent foundation stops growing, future work can stay under 15 without effort.
🤖 Generated with Claude Code