Conversation
This might be accessed by multiple threads during FLB_OUTPUT_RETURN
This reverts commit b79cb3c.
hsmatulis
commented
Dec 11, 2020
|
|
||
| /* Get the authorization token */ | ||
| std::unique_lock<std::mutex> lock(ctx->mutex); | ||
| char* c_token = get_google_token(plg_ctx); |
hsmatulis
commented
Dec 11, 2020
| } | ||
|
|
||
|
|
||
| extern "C" void stackdriver_cpp_flush(struct flb_stackdriver * plg_ctx, struct flb_thread* calling_thread, const char* data, size_t data_len, const char* tag, int tag_len) { |
Owner
Author
There was a problem hiding this comment.
Document lifetime of variables and thread control
hsmatulis
added a commit
that referenced
this pull request
Dec 21, 2020
|
This PR is stale because it has been open 45 days with no activity. Remove stale label or comment or this will be closed in 10 days. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a prototype C++ multi threading implementation for the stackdriver output plugin.
It uses boost::asio and boost::beast, which use openssl. However, the code currently does not use
async IO. One further improvement is to do that. boost::asio supports a lot of ways to do that.