ci: publish @hostess/browser and fix workspace:* rewrite in publish flow - #5
Merged
Merged
Conversation
@hostess/nextjs 0.2.0 has a runtime dependency on @hostess/browser, but the publish workflow only published nextjs — and published it with `npm publish` from the workspace, which would have shipped the workspace:* protocol string verbatim (uninstallable). Pack each package with pnpm (which rewrites workspace deps to real versions), publish browser before nextjs, and skip versions already on the registry so release re-runs are safe. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
|
Bugbot is not enabled for your account, so this pull request was not reviewed. Enable Bugbot in the Cursor dashboard to get automatic reviews on future PRs. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Two publish-flow bugs that would have broken the first npm install of
@hostess/nextjs@0.2.0:@hostess/browserwas never published. nextjs 0.2.0 depends on it at runtime, so installs would fail to resolve it. The workflow now publishes browser first, then nextjs.npm publishfrom the workspace shipsworkspace:*verbatim — npm doesn't understand pnpm's workspace protocol, so the published nextjs would have had an uninstallable dependency string. Packages are now packed withpnpm pack(verified locally: the tarball's dependency reads"@hostess/browser": "0.1.0") and the tarball is published with the OIDC-capable npm, keeping trusted publishing + provenance unchanged.Also skips versions already on the registry, so re-running a release or releasing a single bumped package is safe.
Action needed outside this PR:
@hostess/browseris a brand-new package — npm trusted publishing can't create a package, so its very first0.1.0publish must be done manually (pnpm pack+npm publishwith a real login), then the trusted publisher configured at npmjs.com for it like the existing@hostess/nextjsone.🤖 Generated with Claude Code