Pass the full VisitProposal to registered RouteDecisionHandler instances#249
Merged
Conversation
svara
marked this pull request as ready for review
July 6, 2026 07:08
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pass
VisitProposalto route decision handlersRoute decision handlers previously only received the destination
locationURL, which limited the routing logic apps could implement. This change passes the fullVisitProposalinstead — giving apps access to the location, visit options, path configuration properties, and parameters so they can build more comprehensiveRouteDecisionHandlers.RouteDecisionHandler.matches(location: URL, ...)→matches(proposal: VisitProposal, ...)RouteDecisionHandler.handle(location: URL, ...)→handle(proposal: VisitProposal, ...)Apps with custom
RouteDecisionHandlerimplementations will need to update their signatures. The location is still available viaproposal.url.Notes
Routernow logs the full proposal (rather than just the location) when a handler matches or when no handler is found.Mirrors hotwired/hotwire-native-android#203.