Use PathIdentifiable for navigation identity checks#237
Closed
alpkeser wants to merge 1 commit into
Closed
Conversation
visitingSamePage and visitingPreviousPage fell back to view-controller type equality for non-Visitable / non-VisitableViewController candidates, so two instances of the same custom class with different URLs were indistinguishable — causing an incorrect pop or replace instead of a push.
svara
approved these changes
May 4, 2026
svara
left a comment
svara
left a comment
Contributor
There was a problem hiding this comment.
This is ok as a temporary fix(not merging to main).
Long term, we should aim to have something similar to Android where the library takes care of assigning the destination URL automatically.
Contributor
|
Closing in favor of #248. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
visitingSamePageandvisitingPreviousPagefall back to view-controller type equality when the candidate isn't aVisitable/VisitableViewController. Two instances of the same custom class with different URLs are then indistinguishable, causing an incorrect pop or replace instead of a push.Adds a
PathIdentifiableprotocol exposinginitialVisitableURL.Visitableinherits from it (existing conformers are unchanged), and both checks now prefer URL identity over type identity. Custom native view controllers can opt in by conforming toPathIdentifiable.