Skip to content

Don't pop if not redirecting from MODAL session#192

Closed
joemasilotti wants to merge 1 commit into
mainfrom
modal-redirect-fix
Closed

Don't pop if not redirecting from MODAL session#192
joemasilotti wants to merge 1 commit into
mainfrom
modal-redirect-fix

Conversation

@joemasilotti

Copy link
Copy Markdown
Member

Fixes #190.

@leonvogt

leonvogt commented Nov 3, 2025

Copy link
Copy Markdown
Contributor

This PR also resolves a redirection animation issue I've encountered while testing the v1.3.0 beta.
Before v1.3.0, redirecting to the previously visited URL would result in popping the view controller with an animation. In v1.3.0 beta, this animation is missing.

v1.2.2 behavior:
https://github.com/user-attachments/assets/c5182985-1a06-4db7-a2b6-94f660ff365d

v1.3.0 beta behavior:
https://github.com/user-attachments/assets/b5388556-a282-4460-94bd-d6db129e6acb

This PR restores that pop animation 🎉
Thank you @joemasilotti.

@joemasilotti joemasilotti added this to the v1.3.0 milestone Nov 6, 2025
@JulianKnoche

Copy link
Copy Markdown

@joemasilotti would it be possible to merge this PR soon? My team is experiencing this issue as well and we'd love to not having to build workarounds. Thank you! 🙏

@svara

svara commented Jul 6, 2026

Copy link
Copy Markdown
Contributor

@dennispaagman @leonvogt @JulianKnoche Could you guys try #251 to see if it works for you?

@svara

svara commented Jul 7, 2026

Copy link
Copy Markdown
Contributor

Closing in favor of #251.

@svara svara closed this Jul 7, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

Redirects misbehaving, missing back button or back button goes back to wrong page

4 participants