Hide native title when HTML <title> is not present or blank#204
Open
leonvogt wants to merge 1 commit into
Open
Hide native title when HTML <title> is not present or blank#204leonvogt wants to merge 1 commit into
<title> is not present or blank#204leonvogt wants to merge 1 commit into
Conversation
leonvogt
commented
Jul 10, 2026
Comment on lines
+392
to
+395
| substringAfter("://") | ||
| .removePrefix("www.") | ||
| .replace("%20", " ") | ||
| .trimEnd('/') |
Contributor
Author
There was a problem hiding this comment.
First I had a simpler check, but the problem is that, webView.url contains the schema while webView.title doesnt':
webView.url = http://192.168.42.51:3000/dashboard
webView.title = 192.168.42.51:3000/dashboard
To also handle the case of www.domain.com sites, we we normalize both strings the same way before comparing them.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Android's WebView returns the URL when a page has no HTML
<title>.With this PR, instead of showing the URL, it shows nothing - like in Hotwire Native iOS.