Fixed: issue of product identifier by updating the dxp store and passing action from adapter

[ymaheshwari1]

Related Issues

The issue was due to migrating to latest dxp package, thus states were not updated properly

Short Description and Why It's Useful

Screenshots of Visual Changes before/after (If There Are Any)

Contribution and Currently Important Rules Acceptance

• I read and followed contribution rules

[gemini-code-assist]

Summary of Changes

Hello, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request resolves an issue related to product identification by streamlining the management of e-commerce store preferences. It introduces new capabilities to the application's adapter and integrates them globally within the Vue application. Crucially, it updates the user authentication and store selection processes to leverage the useUserStore from @hotwax/dxp-components, ensuring that user-selected e-commerce store preferences are consistently applied and maintained.

Highlights

• Adapter Enhancements: The adapter now exposes setUserPreference and getUserPreference functions from the @hotwax/oms-api library, making them available for use throughout the application.
• Global Vue Integration: The newly exposed setUserPreference and getUserPreference functions have been integrated into the global properties of the Vue application, allowing direct access from any component.
• DXP Store Preference Management: The user store's actions have been updated to utilize useUserStore from @hotwax/dxp-components for managing e-commerce store preferences, ensuring that the currentEComStore and setEComStorePreference are correctly handled during user login and when explicitly setting the e-commerce store.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Changelog

• src/adapter/index.ts
  • Added setUserPreference and getUserPreference to the list of exported functions from @hotwax/oms-api.
• src/main.ts
  • Imported setUserPreference and getUserPreference from the local adapter.
  • Registered getUserPreference and setUserPreference as global properties on the Vue application instance.
• src/store/modules/user/actions.ts
  • Imported useUserStore from @hotwax/dxp-components.
  • Modified the login action to set useUserStore().currentEComStore, dispatch setEcomStore, and call useUserStore().setEComStorePreference with the preferredStore.
  • Modified the setEcomStore action to additionally call useUserStore().setEComStorePreference with the provided e-commerce store.

Activity

• No specific activity has been recorded for this pull request yet.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[gemini-code-assist]

Code Review

This pull request aims to fix an issue with product identifiers by integrating more deeply with the dxp-components store. The changes involve passing down setUserPreference and getUserPreference from the adapter to the dxpComponents plugin, and updating the user-related Vuex actions to use the dxp-components user store. My review focuses on the user actions file, where I've identified some redundancy and potential race conditions. I've provided suggestions to clean up the code and make it more robust.