Implemented: support to use i18n from dxp and removed app level configuration of i18n(dxp/280)#282
Open
R-Sourabh wants to merge 10 commits into
Open
Implemented: support to use i18n from dxp and removed app level configuration of i18n(dxp/280)#282R-Sourabh wants to merge 10 commits into
R-Sourabh wants to merge 10 commits into
Conversation
| import Menu from '@/components/Menu.vue'; | ||
| import { defineComponent } from "vue"; | ||
| import { useI18n } from 'vue-i18n' | ||
| // import { useI18n } from 'vue-i18n' |
Contributor
There was a problem hiding this comment.
Remove this if not used.
| TaskQueue.init(); | ||
| OfflineHelper.register(); | ||
| const { t, locale } = useI18n(); | ||
| // const { t, locale } = useI18n(); |
Contributor
There was a problem hiding this comment.
Remove unnecessary comments. Also check everywhere.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related Issues
hotwax/dxp-components#280
Short Description and Why It's Useful
Using i18n configuration from the dxp package will help in having a common place to manage configurations related to internationalization
-Removed i18n package from the app
-Updated all the components and ts file to use translate method from dxp
Screenshots of Visual Changes before/after (If There Are Any)
IMPORTANT NOTICE - Remember to update
CHANGELOG.mdwith description of your changeContribution and Currently Important Rules Acceptance