Drop redundant wheel from the build deps#3
Open
webknjaz wants to merge 2 commits into
Open
Conversation
This is a mistake based on an incorrectly added example in the `setuptools` docs that I've since corrected upstream. It still makes its way into people's projects years after. Originally, `wheel` was being auto-injected as a build dep when building wheels (not just sdist) through the corresponding PEP 517 hook in `setuptools`. Two years ago, at the PyCon US Sprints, Alex's moved the respective `wheel` interface right into `setuptools` and it's no longer pulled in when constructing the build env as it's now vendored. Signed-off-by: 🇺🇦 Sviatoslav Sydorenko (Святослав Сидоренко) <webknjaz@redhat.com>
Signed-off-by: 🇺🇦 Sviatoslav Sydorenko (Святослав Сидоренко) <webknjaz@redhat.com>
webknjaz
commented
May 15, 2026
| return env_dir / "bin" / "python" | ||
|
|
||
|
|
||
| def _bootstrap_build_backend(python_bin: Path) -> None: |
Author
There was a problem hiding this comment.
Though, you could really just use pypa/build for this w/o manual venv management. Or even just a pip install --no-deps which would've built an sdist first and then wheel from sdist (not from Git like you're doing now — this isn't what happens in real envs).
Author
There was a problem hiding this comment.
FWIW, I've got https://github.com/re-actors/checkout-python-sdist for testing from sdist in CI, just like what the downstreams would do.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a mistake based on an incorrectly added example in the
setuptoolsdocs that I've since corrected upstream. It still makes its way into people's projects years after.Originally,
wheelwas being auto-injected as a build dep when building wheels (not just sdist) through the corresponding PEP 517 hook insetuptools. Two years ago, at the PyCon US Sprints, Alex's moved the respectivewheelinterface right intosetuptoolsand it's no longer pulled in when constructing the build env as it's now vendored.