Update MKL and LAPACK flags#119
Open
Andres-MG wants to merge 4 commits into
Open
Conversation
Collaborator
|
@Andres-MG, it seems the change is not compiling? |
Collaborator
Author
|
Yes, I have been working on some other stuff and I couldn't finish this. I will try to go back to this and fix it this week hopefully. |
Collaborator
Author
|
I think this PR can be closed without merging, the code works fine and the new testing strategy covers this better. Of course, we can keep it open if anyone wants to have a look. |
Collaborator
|
I took a look to the code while fixing the makefile. I am not sure that the code is perfect. I think that inside the code, MKL and LAPACK are sometimes interchanged. Let's keep the PR open, in case someone wants to take a look, but I agree it does not make sense to merge it now. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Remove deprecation warning from ifort with -mkl flag, and separate MKL from LAPACK since MKL adds more functionality on top of LAPACK.
Closes #114.