fix(turba): harden contacts search field mapping for ActiveSync#60
Merged
Conversation
Avoid nesting source-keyed field lists when defaulting the search source, and skip non-string field names when building criteria.
ralflang
approved these changes
Jun 18, 2026
ralflang
added a commit
that referenced
this pull request
Jun 30, 2026
Release version 5.0.0 chore: update CI Merge pull request #60 from horde/fix/activesync-search-fields docs(api): explain fields-shape fallback in search() fix(turba): harden contacts search field mapping for ActiveSync refactor(session): drop $_SESSION read for has_share
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Turba_Api::search()when defaulting address book sources leaves a nestedfieldsstructureMotivation
ActiveSync
ResolveRecipientscallscontacts/searchwith per-source field maps. When all configured sources are filtered out, Turba assigned the entire keyedfieldsarray to the default source. That produced nested arrays and$criteria[$field]crashes (Cannot access offset of type array on array).Changes
is_string($field)Test plan
ResolveRecipientswhile composing a meeting invite on iOS (no Turba TypeError inhorde.log)