Refactor tasklist cache and sync list handling#28
Merged
Conversation
ralflang
approved these changes
May 28, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Nag: conditional web session refresh for task list changes
Summary
Adopts the Kronolith pattern for keeping the Nag web UI in sync when task lists change via ActiveSync or another session, without reloading prefs and share caches on every page view.
Problem
With horde/nag#25,
refreshWebSessionState()ran on every Nag request (prefs->cleanup()/retrieve()plus share list cache expiry). That works but is costly (review comment). List changes from iOS or a second browser tab also need other web sessions to notice without a full logout.Solution
Horde_Cache(nag.tasklist_cache_ts.<user>), not in user preferences.tasklist_cache_tsin the PHP session; run the expensive reload only when the marker is newer.markTasklistCacheChanged()fromnotifyActiveSyncOfTaskListChange()(always, even if ActiveSync is disabled) and when adding a display-only task list.display_tasklists/sync_lists, refresh default and sync lists (getSyncLists(true)), persist prefs, update session marker.ActiveSync device cache behaviour from #25 is unchanged (
hierarchy = 0, no prune innotify, collection-only delete).Files changed
lib/Nag.phpTest plan
horde.log.activesync_no_multiplex+sync_lists).