fix(ingo): register Ingo\ PSR-4 autoload for V3 form types#33
Merged
Conversation
Horde_Form resolves ingo:Longemail and ingo:folders to Ingo\Form\V3\* classes. The V3 migration removed legacy lib/Form/Type/Longemail.php but autoload was switched to Horde\Ingo\ only, leaving those classes unloadable.
There was a problem hiding this comment.
Pull request overview
Registers the Ingo\ PSR-4 namespace to src/ (in both Composer and Horde build metadata) so Horde’s V3 form variable lookup can autoload Ingo\Form\V3\*Variable classes and avoid fatals on affected filter pages.
Changes:
- Add
Ingo\\ => src/tocomposer.jsonautoload.psr-4. - Mirror the same
Ingo\ => src/mapping in.horde.ymlto keep Horde packaging/build autoload metadata consistent.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| composer.json | Adds PSR-4 autoload entry for Ingo\ so V3 form variable classes under src/Form/V3 can be found. |
| .horde.yml | Mirrors the Ingo\ PSR-4 mapping for Horde’s build/packaging metadata consistency. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Member
|
I do not think this is the right fix. All classes in Based on error message I think the reporter just has an outdated |
Contributor
Author
|
changes reverted, thanks for the hint @amulet1 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Ingo\→src/PSR-4 autoload in composer.json and .horde.ymlMotivation
After the V3 form migration (91cbbb2), custom field types live in
Ingo\Form\V3\LongemailVariableandIngo\Form\V3\FoldersVariable.Horde_Form::createVariable()looks up{App}\Form\V3\{Type}Variable,but only
Horde\Ingo\was autoloaded fromsrc/, so pages usingingo:Longemailoringo:folderscrashed with "Nonexistent classIngo_Form_Type_Longemail".
Changes
"Ingo\\": "src/"to autoload.psr-4 in composer.jsonTest plan
Made with Cursor