Skip to content

fix(prefs): cast values to string before binary SQL storage #7

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ralflang merged 2 commits into from
Jun 18, 2026
Merged

fix(prefs): cast values to string before binary SQL storage #7

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
aec888d
fix(prefs): cast values to string before binary SQL storage
TDannhauer Jun 17, 2026
8bd7f6d
fix(prefs): apply review feedback, strval before charset conversion
TDannhauer Jun 18, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 8 additions & 2 deletions lib/Horde/Prefs/Storage/Sql.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,6 +13,8 @@
* @package Prefs
*/

use Horde\Util\HordeString;

/**
* Preferences storage implementation for a SQL database.
*
Expand Down Expand Up @@ -125,8 +127,12 @@ public function store($scope_ob)
throw new Horde_Prefs_Exception($e);
}

/* Driver has no support for storing locked status. */
$value = Horde_String::convertCharset($value, 'UTF-8', $charset);
/* Driver has no support for storing locked status.
* strval() before charset conversion so non-string scalars
* (e.g. integer 0/1 from checkbox prefs) are normalized
* before reaching the PDO blob layer, which serializes
* string data only. */
$value = HordeString::convertCharset(strval($value), 'UTF-8', $charset);
$value = new Horde_Db_Value_Binary($value);

if (empty($check)) {
Expand Down
Loading