Skip to content

fix(search): provide empty-string fallback for missing attributes in sortedAsArray() #5

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ralflang merged 1 commit into from
Apr 13, 2026
Merged

fix(search): provide empty-string fallback for missing attributes in sortedAsArray() #5

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 10 additions & 2 deletions lib/Horde/Ldap/Search.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -264,11 +264,19 @@ public function sortedAsArray(array $attrs = ['cn'], $order = SORT_ASC)
}

// Build columns for array_multisort(). Each requested attribute is one
// row.
// row. Not every entry necessarily has every requested attribute, so
// we provide an empty-string fallback to avoid undefined array key
// warnings in PHP 8.0+ while keeping the reference binding that
// array_multisort() requires.
$columns = [];
foreach ($attrs as $attr_name) {
foreach ($to_sort as $key => $row) {
$columns[$attr_name][$key] = & $to_sort[$key][$attr_name][0];
if (isset($to_sort[$key][$attr_name][0])) {
$columns[$attr_name][$key] = & $to_sort[$key][$attr_name][0];
} else {
$to_sort[$key][$attr_name] = [''];
$columns[$attr_name][$key] = & $to_sort[$key][$attr_name][0];
}
}
}

Expand Down
Loading