fix(date): accept DateTimeInterface in legacy Horde_Date constructor#17
Merged
ralflang merged 2 commits intoJun 24, 2026
Merged
Conversation
_initializeFromObject() only handled DateTime, so DateTimeImmutable and other DateTimeInterface values produced invalid years and broke saves that flow through Nag and other legacy callers. Add regression tests for DateTimeImmutable and parsed ICU dates.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
DateTimeInterfaceinHorde_Date::_initializeFromObject()DateTimeImmutableand ICU-parsed datesMotivation
Constructing
Horde_DatefromDateTimeImmutable(or fromHorde\Date\Date::toDateTimeImmutable()after ICU parsing) fell through to invalid internal state (year -1), which broke Nag task saves and could export epoch due dates to ActiveSync.Changes
lib/Horde/Date.php: useinstanceof \DateTimeInterfacein_initializeFromObject()test/Unnamespaced/DateTest.php: cover immutable and parsed date constructionTest plan
vendor/bin/phpunit test/Unnamespaced/DateTest.php(constructor test)