fix(activesync): harden base64 URI decoding for GET requests#73
Merged
Conversation
Reject malformed QUERY_STRING payloads before unpack() instead of logging PHP warnings for unknown commands and truncated device IDs. Add missing EAS command codes and skip DeviceType normalization when decode returns no Cmd.
ralflang
approved these changes
Jul 1, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Horde_ActiveSync_Utils::decodeBase64()against malformedQUERY_STRINGvaluesMotivation
Non-ActiveSync requests hitting the ActiveSync endpoint with a long enough
QUERY_STRINGwere base64-decoded as garbage, producing PHP warnings for unknown command bytes, failedunpack()calls, and undefinedDeviceTypeaccess ingetGetVars().Changes
unpack()DeviceTypenormalization with?? ''and only accept decoded results whenCmdis presentTest plan
vendor/bin/phpunit --bootstrap vendor/autoload.php vendor/horde/activesync/test/unit/Horde/ActiveSync/UtilsTest.php