feat: Use depot.dev runners#724
Merged
Merged
Conversation
📝 WalkthroughWalkthroughMigrated GitHub Actions workflows from self-hosted infrastructure runners to cloud-based depot runners across four workflow files. Additionally, updated referenced reusable workflows and actions to newer versions: build-docker from v1 to v2, release-version from v2 to v3, and setup-node-js action reference from commit SHA to version tag. Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Review rate limit: 0/1 reviews remaining, refill in 60 minutes.Comment |
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 2
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Inline comments:
In @.github/workflows/pr.yaml:
- Line 91: Replace the mutable action reference
"hoprnet/hopr-workflows/actions/setup-node-js@setup-node-js-v1" with the
repository action pinned to a specific commit SHA (e.g.
"hoprnet/hopr-workflows/actions/setup-node-js@<commit-sha>"); locate the uses
line that contains setup-node-js and substitute the tag with the resolved
immutable commit SHA from the action repository (obtainable via the action repo
commit history or the GitHub Actions Marketplace), then commit the updated
workflow so the action is pinned to that specific SHA.
In @.github/workflows/release.yaml:
- Line 50: Add an actionlint configuration to whitelist the custom Depot runner
labels so actionlint won’t flag the usage of "depot-ubuntu-24.04" (and similar
labels) in workflows; create a file named .actionlintrc.yaml containing a
runner-label-whitelist entry that includes "depot-ubuntu-24.04" and
"depot-ubuntu-24.04-4" (or update your existing actionlint config) so workflows
referencing that label (e.g., the runs-on: depot-ubuntu-24.04 line in
release.yaml and similar occurrences) are allowed by the linter.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: CHILL
Plan: Pro
Run ID: cb17dc90-20b4-455f-bbc0-15c2c108ce01
📒 Files selected for processing (4)
.github/workflows/checks-zizmor.yaml.github/workflows/merge.yaml.github/workflows/pr.yaml.github/workflows/release.yaml
🔎 Trivy Security Report
|
Contributor
Author
|
@mjadach-iv It's worth to upgrade the docker image and it's dependencies in a future PR |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Use depot.dev runners instead of self hosted
Summary by CodeRabbit