Release sync: merge develop into main for v1.24.0 test fixes#87
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR syncs develop into main for the v1.24.0 release state, primarily to align main with the updated Connect-HaloAPI Key Vault unit tests (managed identity switch + Key Vault secret name/value behavior) so release history reflects a passing test baseline.
Changes:
- Update
Connect-HaloAPIunit tests to use-UseManagedIdentity(instead of the prior-Identityargument pattern). - Update Key Vault secret naming in tests from underscore-delimited to hyphen-delimited (e.g.,
halo-URL). - Update Key Vault secret mock returns to match
Get-AzKeyVaultSecret -AsPlainTextbehavior (plain text values).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Included changes
Validation
Issues