Release: Merge 1.24.0 stable to main#86
Merged
Merged
Conversation
…ve fragment handling
…lt integration (#85)
Contributor
There was a problem hiding this comment.
Pull request overview
This PR merges the 1.24.0 release line into main for the HaloAPI PowerShell module, introducing new CustomTable row-data cmdlets, enhancing Invoke-HaloRequest usability, and fixing Azure Key Vault integration in Connect-HaloAPI.
Changes:
- Added
New/Set/Remove-HaloCustomTableDatacmdlets with unit tests to manage CustomTable row data. - Enhanced
Invoke-HaloRequestto support direct parameters, fragment resolution, and response property expansion, plus additional unit tests. - Updated
Connect-HaloAPIKey Vault behavior (hyphenated secret names,-AsPlainText,UseManagedIdentityswitch) and bumped release metadata/changelog.
Reviewed changes
Copilot reviewed 9 out of 9 changed files in this pull request and generated 9 comments.
Show a summary per file
| File | Description |
|---|---|
| Tests/HaloAPI.Unit.Tests.ps1 | Adds unit coverage for new Invoke-HaloRequest behaviors and CustomTableData cmdlets. |
| Public/New/New-HaloCustomTableData.ps1 | New cmdlet to POST CustomTable row data payloads. |
| Public/Set/Set-HaloCustomTableData.ps1 | New cmdlet to update CustomTable row data payloads. |
| Public/Remove/Remove-HaloCustomTableData.ps1 | New cmdlet to delete CustomTable data via delete-flag payloads. |
| Public/Invoke/Invoke-HaloRequest.ps1 | Adds direct-parameter usage, fragment resolution, and ExpandProperty support; adjusts token-renew flow. |
| Public/Get/Get-HaloTicket.ps1 | Adds -ExcludeSLA switch to the ticket query surface. |
| Public/Connect-HaloAPI.ps1 | Fixes Key Vault integration and adjusts parameter requirements/managed identity behavior. |
| HaloAPI.psd1 | Updates version and exported functions; adjusts release metadata. |
| CHANGELOG.md | Adds 1.24.0 release notes entry. |
Comment on lines
90
to
+97
| $ReconnectParameters = @{ | ||
| URL = $Script:HAPIConnectionInformation.URL | ||
| ClientId = $Script:HAPIConnectionInformation.ClientID | ||
| URL = $Script:HAPIConnectionInformation.URL | ||
| ClientId = $Script:HAPIConnectionInformation.ClientID | ||
| ClientSecret = $Script:HAPIConnectionInformation.ClientSecret | ||
| Scopes = $Script:HAPIConnectionInformation.AuthScopes | ||
| Tenant = $Script:HAPIConnectionInformation.Tenant | ||
| Scopes = $Script:HAPIConnectionInformation.AuthScopes | ||
| Tenant = $Script:HAPIConnectionInformation.Tenant | ||
| } | ||
| Connect-HaloAPI @ReconnectParameters | ||
| $null = Connect-HaloAPI @ReconnectParameters -NoConfirm |
Comment on lines
+111
to
+123
| if ($PSCmdlet.ParameterSetName -eq 'RequestParameters') { | ||
| $WebRequestParams = @{ | ||
| Method = $Method | ||
| } | ||
|
|
||
| if (-not [string]::IsNullOrWhiteSpace($Uri)) { | ||
| $WebRequestParams.Uri = $Uri | ||
| } | ||
|
|
||
| if (-not [string]::IsNullOrWhiteSpace($Fragment)) { | ||
| $WebRequestParams.Fragment = $Fragment | ||
| } | ||
|
|
Comment on lines
+19
to
+20
| .PARAMETER Uri | ||
| Absolute URI for the request. |
Comment on lines
+92
to
+103
| # Validate that required parameters are provided when not using KeyVault | ||
| if (-not $UseKeyVault -and -not $SaveToKeyVault) { | ||
| if ([string]::IsNullOrWhiteSpace($URL)) { | ||
| throw 'URL parameter is required when UseKeyVault is not specified.' | ||
| } | ||
| if ([string]::IsNullOrWhiteSpace($ClientID)) { | ||
| throw 'ClientID parameter is required when UseKeyVault is not specified.' | ||
| } | ||
| if ([string]::IsNullOrWhiteSpace($ClientSecret)) { | ||
| throw 'ClientSecret parameter is required when UseKeyVault is not specified.' | ||
| } | ||
| } |
Comment on lines
105
to
106
| # If the Identity parameter is specified, use it to connect. | ||
| # Otherwise, fall back to interactive login. |
Comment on lines
+73
to
79
| # When set to $true, uses a Managed Identity to connect to Azure Key Vault instead of interactive login. | ||
| [Parameter( | ||
| ParameterSetName = 'Client Credentials', | ||
| Mandatory = $False | ||
| )] | ||
| [String]$Identity, | ||
| [Switch]$UseManagedIdentity, | ||
| # The maximum number of times to retry requests before giving up. |
Comment on lines
+322
to
326
| ReleaseNotes = 'https://github.com/homotechsual/HaloAPI/releases/tag/v1.24.0-beta1' | ||
|
|
||
| # Prerelease string of this module | ||
| # Prerelease = 'Beta1' | ||
| Prerelease = 'beta1' | ||
| # Flag to indicate whether the module requires explicit user acceptance for install/update/save |
| ) | ||
| Invoke-HaloPreFlightCheck | ||
| try { | ||
| if ($PSCmdlet.ShouldProcess($CustomTableData -is [Array] ? 'Custom Table Data' : 'Custom Table Data', 'Create')) { |
| ) | ||
| Invoke-HaloPreFlightCheck | ||
| try { | ||
| if ($PSCmdlet.ShouldProcess($CustomTableData -is [Array] ? 'Custom Table Data' : 'Custom Table Data', 'Update')) { |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR merges the 1.24.0 stable release from develop to main.
Closes #83, #84, #85
Changes