Add Room Average Temperature sensor to Lyric integration - #177063
Open
clutch2sft wants to merge 1 commit into
Open
Add Room Average Temperature sensor to Lyric integration#177063clutch2sft wants to merge 1 commit into
clutch2sft wants to merge 1 commit into
Conversation
Resideo's priority endpoint reports a room-level average temperature (roomAvgTemp) alongside the per-accessory temperature already exposed as Room Temperature. This was parsed but never surfaced. Adds it as a sibling entry to the existing Room Humidity sensor, which already uses the same room-level (not accessory-level) value.
home-assistant
Bot
added
cla-signed
integration: lyric
new-feature
small-pr
Contributor
|
Hey there @timmo001, mind taking a look at this pull request as it has been labeled with an integration ( Code owner commandsCode owners of
|
Contributor
There was a problem hiding this comment.
Pull request overview
Adds a room-average temperature sensor to the Lyric integration.
Changes:
- Adds a temperature sensor backed by
room_avg_temp. - Adds the corresponding entity translation.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
homeassistant/components/lyric/sensor.py |
Defines the room-average temperature sensor. |
homeassistant/components/lyric/strings.json |
Adds its display name. |
| translation_key="room_average_temperature", | ||
| device_class=SensorDeviceClass.TEMPERATURE, | ||
| state_class=SensorStateClass.MEASUREMENT, | ||
| value_fn=lambda room, _: room.room_avg_temp, |
| value_fn=lambda room, _: room.room_avg_humidity, | ||
| suitable_fn=lambda _, accessory: accessory.type == "IndoorAirSensor", | ||
| ), | ||
| LyricSensorAccessoryEntityDescription( |
Comment on lines
+64
to
+66
| "room_average_temperature": { | ||
| "name": "Room average temperature" | ||
| }, |
Author
There was a problem hiding this comment.
Documentation added/updated for www.home-assistant.io
Link to documentation pull request: home-assistant/home-assistant.io#46986
8 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resideo's priority endpoint reports a room-level average temperature (roomAvgTemp) alongside the per-accessory temperature already exposed as Room Temperature. This was parsed but never surfaced. Adds it as a sibling entry to the existing Room Humidity sensor, which already uses the same room-level (not accessory-level) value.
Proposed change
Resideo's priority endpoint reports a room-level average temperature
(
roomAvgTemp/avgTemperature) alongside the per-accessory temperature alreadyexposed as Room Temperature. This was parsed but never surfaced. Adds it as a
sibling entry to the existing Room Humidity sensor, which already uses the same
room-level (not accessory-level) value.
Dependency note: this needs both #177022 (coordinator actually fetching room data)
and the pending aiolyric field-name fix (
room_avg_tempcurrently reads the wrongJSON key) to show real data. Safe to merge independently — it'll just report
unavailableuntil both land, same as the existing Room Humidity sensor alreadydoes today.
Type of change
Additional information
room_avg_temp's JSON key (part oftimmo001/aiolyric#165)Checklist
ruff format homeassistant tests)If user exposed functionality or configuration variables are added/changed:
Link to documentation pull request: Lyric binary sensor and new sensors docs home-assistant.io#46986
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest.requirements_all.txt.Updated by running
python3 -m script.gen_requirements_all.To help with the load of incoming pull requests: