Add oven controls (number, select, button) to Whirlpool by bdlcalvin · Pull Request #173326 · home-assistant/core

bdlcalvin · 2026-06-09T00:59:48Z

Proposed change

Adds oven controls to the Whirlpool integration. Per review feedback (thanks @joostlek), this no longer uses a climate entity — instead, following the SmartThings/Miele pattern, oven cavities get:

a number for the target temperature (settable),
a select for the cook mode (Bake / Convection bake / Broil / …),
a button to stop the current cook,
alongside the existing current temperature and state sensors.

The redundant read-only target-temperature and cook-mode sensors are removed, since the number/select now cover them. One entity set per cavity (single, or upper + lower).

The Whirlpool API couples target temp + mode into one set_cook call, so the number sends the temp with the current mode, the select sends the mode with the current/last temp, and the button issues stop_cook.

Type of change

New feature

Additional information

Replaces the earlier climate-based approach in this same PR. Snapshots are being regenerated; CI may be briefly red on snapshots until that commit lands.

home-assistant

Hi @bdlcalvin

It seems you haven't yet signed a CLA. Please do so here.

Once you do that we will be able to review and accept this pull request.

Thanks!

home-assistant · 2026-06-09T00:59:56Z

Hey there @abmantis, @mkmer, mind taking a look at this pull request as it has been labeled with an integration (whirlpool) you are listed as a code owner for? Thanks!

Code owner commands

Code owners of whirlpool can trigger bot actions by commenting:

@home-assistant close Closes the pull request.
@home-assistant mark-draft Mark the pull request as draft.
@home-assistant ready-for-review Remove the draft status from the pull request.
@home-assistant rename Awesome new title Renames the pull request.
@home-assistant reopen Reopen the pull request.
@home-assistant unassign whirlpool Removes the current integration label and assignees on the pull request, add the integration domain after the command.
@home-assistant update-branch Update the pull request branch with the base branch.
@home-assistant add-label needs-more-information Add a label (needs-more-information, problem in dependency, problem in custom component, problem in config, problem in device, feature-request) to the pull request.
@home-assistant remove-label needs-more-information Remove a label (needs-more-information, problem in dependency, problem in custom component, problem in config, problem in device, feature-request) on the pull request.

Copilot

Pull request overview

Note

Copilot was unable to run its full agentic suite in this review.

This PR adds oven climate entity support to the Whirlpool integration, allowing oven cavities to be controlled via the Home Assistant climate platform with temperature control, cook mode presets, and on/off functionality.

Changes:

Adds OvenEntity class to climate.py that represents oven cavities as climate entities with HVAC modes (OFF/HEAT), preset modes for cook modes, and temperature control.
Adds translation strings in strings.json for oven climate entity preset modes (bake, broil, air fry, etc.) for single and dual cavity ovens.
Adds comprehensive tests for the new oven climate entities covering dynamic attributes, temperature setting, preset modes, on/off, and error handling.

Reviewed changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.

File	Description
homeassistant/components/whirlpool/climate.py	Adds `OvenEntity` class with cook mode mappings, temperature config, and HVAC/preset/temp control methods
homeassistant/components/whirlpool/strings.json	Adds translation keys for oven climate preset modes (single + dual cavity)
tests/components/whirlpool/test_climate.py	Adds parametrized tests for oven climate entity attributes, services, and error handling

+    def hvac_action(self) -> HVACAction:
+        """Return the current action."""
+        if self._appliance.get_cavity_state(self.cavity) in OVEN_ACTIVE_STATES:
+            return HVACAction.HEATING
+        return HVACAction.OFF


+async def test_oven_service_request_failure(
+    hass: HomeAssistant,
+    oven_climate_entity: tuple[str, str, "whirlpool.oven.Cavity"],
+    request: pytest.FixtureRequest,
+) -> None:
+    """Test a failed oven request raises HomeAssistantError."""
+    entity_id, mock_fixture, _ = oven_climate_entity
+    mock = request.getfixturevalue(mock_fixture)
+    mock.set_cook.return_value = False
+    await init_integration(hass)
+
+    with pytest.raises(HomeAssistantError):
+        await hass.services.async_call(
+            CLIMATE_DOMAIN,
+            SERVICE_SET_TEMPERATURE,
+            {ATTR_ENTITY_ID: entity_id, ATTR_TEMPERATURE: 220},
+            blocking=True,
+        )


Copilot

Pull request overview

Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.

+    mock.get_cavity_state.return_value = whirlpool.oven.CavityState.Cooking
+    await trigger_attr_callback(hass, mock)
+    assert hass.states.get(entity_id).state == HVACMode.HEAT


Copilot

Pull request overview

Copilot reviewed 4 out of 4 changed files in this pull request and generated no new comments.

joostlek

So we have discussed this with other integrations before like smartthings and miele, but while these devices provide good data points for climate entities, we actually don't want them to have as climate entities. Reason for this is that climate entities are meant to control the climate of a room/area. This will lead to weird behaviors like for example asking voice to turn the temperature in the kitchen to 20 degrees, and then the oven suddenly turns to 20 degrees. Instead, having separate number and sensor entities would work better and give a more consistent experience

Copilot

Pull request overview

Copilot reviewed 11 out of 11 changed files in this pull request and generated 3 comments.

+    'aliases': list([
+      None,
+    ]),


+    "climate": {
+      "oven": {
+        "state_attributes": {
+          "preset_mode": {
+            "state": {
+              "air_fry": "[%key:component::whirlpool::entity::sensor::oven_cook_mode::state::air_fry%]",
+              "bake": "[%key:component::whirlpool::entity::sensor::oven_cook_mode::state::bake%]",
+              "broil": "[%key:component::whirlpool::entity::sensor::oven_cook_mode::state::broil%]",
+              "convection_bake": "[%key:component::whirlpool::entity::sensor::oven_cook_mode::state::convection_bake%]",
+              "convection_broil": "[%key:component::whirlpool::entity::sensor::oven_cook_mode::state::convection_broil%]",
+              "convection_roast": "[%key:component::whirlpool::entity::sensor::oven_cook_mode::state::convection_roast%]",
+              "keep_warm": "[%key:component::whirlpool::entity::sensor::oven_cook_mode::state::keep_warm%]"


gjohansson-ST · 2026-06-09T14:40:34Z

You should break it out to one platform per PR

joostlek

Please make sure we keep the PR well scoped. I think a PR per platform would fit the best

Copilot

Pull request overview

Copilot reviewed 14 out of 14 changed files in this pull request and generated 3 comments.

+            await self._appliance.set_cook(
+                target_temp=value, mode=mode, cavity=self.cavity
+            )


+    await hass.services.async_call(
+        SELECT_DOMAIN,
+        SERVICE_SELECT_OPTION,
+        {ATTR_ENTITY_ID: entity_id, ATTR_OPTION: "broil"},
+        blocking=True,
+    )
+    mock.set_cook.assert_called_once_with(
+        target_temp=200, mode=whirlpool.oven.CookMode.Broil, cavity=cavity
+    )


+    await hass.services.async_call(
+        NUMBER_DOMAIN,
+        SERVICE_SET_VALUE,
+        {ATTR_ENTITY_ID: entity_id, ATTR_VALUE: 220},
+        blocking=True,
+    )
+    mock.set_cook.assert_called_once_with(
+        target_temp=220, mode=whirlpool.oven.CookMode.Bake, cavity=cavity
+    )


bdlcalvin · 2026-06-09T22:54:14Z

Splitting this into one PR per platform as requested:

Number (target temperature): Add oven target temperature number to Whirlpool #173411
Select (cook mode): Add oven cook mode select to Whirlpool #173412
Button (stop): Add oven stop button to Whirlpool #173413

Closing this combined PR in favor of those. Thanks for the reviews!

bdlcalvin added 3 commits June 8, 2026 20:59

Whirlpool oven climate: update climate.py

74af2ff

Whirlpool oven climate: update strings.json

e56c22a

Whirlpool oven climate: update test_climate.py

7f1860f

Copilot AI review requested due to automatic review settings June 9, 2026 00:59

home-assistant Bot requested changes Jun 9, 2026

View reviewed changes

home-assistant Bot added cla-needed has-tests integration: whirlpool labels Jun 9, 2026

home-assistant Bot assigned abmantis Jun 9, 2026

home-assistant Bot added the Quality Scale: silver label Jun 9, 2026

Copilot AI reviewed Jun 9, 2026

View reviewed changes

home-assistant Bot added cla-recheck cla-signed and removed cla-recheck cla-needed labels Jun 9, 2026

bdlcalvin added 2 commits June 8, 2026 21:38

Address review: preheating hvac_action + stop_cook failure test

b4d50f0

Address review: preheating hvac_action + stop_cook failure test

8fde6c5

Copilot AI review requested due to automatic review settings June 9, 2026 01:38

Copilot AI reviewed Jun 9, 2026

View reviewed changes

Comment thread tests/components/whirlpool/test_climate.py Outdated

Comment on lines +452 to +454

mock.get_cavity_state.return_value = whirlpool.oven.CavityState.Cooking

await trigger_attr_callback(hass, mock)

assert hass.states.get(entity_id).state == HVACMode.HEAT

bdlcalvin added 2 commits June 9, 2026 07:06

Update climate snapshot for oven entities

7f38705

Fix CI: ruff format, annotation quotes, and one-level translation refs

d6794cc

Copilot AI review requested due to automatic review settings June 9, 2026 11:16

bdlcalvin added 2 commits June 9, 2026 07:16

Fix CI: ruff format, annotation quotes, and one-level translation refs

9678d9c

Fix CI: ruff format, annotation quotes, and one-level translation refs

9f45054

Copilot AI reviewed Jun 9, 2026

View reviewed changes

joostlek reviewed Jun 9, 2026

View reviewed changes

bdlcalvin added 2 commits June 9, 2026 08:01

Rework oven control: number + select + button (drop climate)

83b4dae

Rework oven control: number + select + button (drop climate)

473ccb9

Copilot AI review requested due to automatic review settings June 9, 2026 12:01

bdlcalvin added 10 commits June 9, 2026 08:01

Rework oven control: number + select + button (drop climate)

b8f765a

Rework oven control: number + select + button (drop climate)

f39bea0

Rework oven control: number + select + button (drop climate)

24d142c

Rework oven control: number + select + button (drop climate)

8f37552

Rework oven control: number + select + button (drop climate)

ab73c1a

Rework oven control: number + select + button (drop climate)

afce2b0

Rework oven control: number + select + button (drop climate)

0be8334

Rework oven control: number + select + button (drop climate)

fc50984

Rework oven control: number + select + button (drop climate)

119153f

Rework oven control: number + select + button (drop climate)

73f037b

bdlcalvin changed the title ~~Add oven climate entity to Whirlpool~~ Add oven controls (number, select, button) to Whirlpool Jun 9, 2026

Copilot AI reviewed Jun 9, 2026

View reviewed changes

joostlek requested changes Jun 9, 2026

View reviewed changes

Add oven number/select/button entities; regenerate snapshots

51ee926

Copilot AI review requested due to automatic review settings June 9, 2026 21:26

Copilot AI reviewed Jun 9, 2026

View reviewed changes

This was referenced Jun 9, 2026

Add oven target temperature number to Whirlpool #173411

Open

Add oven cook mode select to Whirlpool #173412

Open

bdlcalvin mentioned this pull request Jun 9, 2026

Add oven stop button to Whirlpool #173413

Open

3 tasks

bdlcalvin closed this Jun 9, 2026

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Add oven controls (number, select, button) to Whirlpool#173326

Add oven controls (number, select, button) to Whirlpool#173326
bdlcalvin wants to merge 22 commits into
home-assistant:devfrom
bdlcalvin:whirlpool-oven-climate

bdlcalvin commented Jun 9, 2026 •

edited

Loading

Uh oh!

home-assistant Bot left a comment

Uh oh!

home-assistant Bot commented Jun 9, 2026

Uh oh!

Copilot AI left a comment

Uh oh!

Copilot AI left a comment

Uh oh!

Copilot AI left a comment

Uh oh!

joostlek left a comment

Uh oh!

Copilot AI left a comment

Uh oh!

gjohansson-ST commented Jun 9, 2026

Uh oh!

joostlek left a comment

Uh oh!

Copilot AI left a comment

Uh oh!

bdlcalvin commented Jun 9, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

Uh oh!

Conversation

bdlcalvin commented Jun 9, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Proposed change

Type of change

Additional information

Uh oh!

home-assistant Bot left a comment

Choose a reason for hiding this comment

Uh oh!

home-assistant Bot commented Jun 9, 2026

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

joostlek left a comment

Choose a reason for hiding this comment

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

gjohansson-ST commented Jun 9, 2026

Uh oh!

joostlek left a comment

Choose a reason for hiding this comment

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

bdlcalvin commented Jun 9, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

bdlcalvin commented Jun 9, 2026 •

edited

Loading