Bump python-roborock to 5.14.1 and revert defensive aiohttp catch#172745
Merged
justanotherariel merged 1 commit intoJun 1, 2026
Merged
Conversation
The library v5.14.1 (Python-roborock/python-roborock#835) wraps network exceptions in RoborockException at the HTTP chokepoint. The integration's existing `except RoborockException` handler in async_setup_entry now catches network failures and raises ConfigEntryNotReady, making the defensive aiohttp.ClientError / TimeoutError catch added in home-assistant#172492 redundant. Paired in one commit so users never have a window without coverage. Per @allenporter's review on home-assistant#172492: home-assistant#172492 (comment) Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
home-assistant
Bot
added
bugfix
cla-signed
has-tests
integration: roborock
small-pr
Contributor
|
Hey there @Lash-L, @allenporter, mind taking a look at this pull request as it has been labeled with an integration ( Code owner commandsCode owners of
|
Contributor
There was a problem hiding this comment.
Pull request overview
Note
Copilot was unable to run its full agentic suite in this review.
Updates the Roborock integration to use a newer python-roborock version and removes the dedicated “network_error” setup-retry handling (and its related test/translation).
Changes:
- Bump
python-roborockfrom5.12.0to5.14.1. - Remove
aiohttp-based network exception handling during config entry setup. - Remove related test and translation string for
network_error.
Reviewed changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| tests/components/roborock/test_init.py | Removes test that asserted setup retries on network exceptions. |
| requirements_all.txt | Updates pinned python-roborock version. |
| homeassistant/components/roborock/strings.json | Removes the network_error error message definition. |
| homeassistant/components/roborock/manifest.json | Updates integration requirement to python-roborock==5.14.1. |
| homeassistant/components/roborock/init.py | Removes handling of network exceptions that previously triggered ConfigEntryNotReady. |
Comment on lines
120
to
125
| translation_domain=DOMAIN, | ||
| translation_key="home_data_fail", | ||
| ) from err | ||
| except (aiohttp.ClientError, TimeoutError) as err: | ||
| _LOGGER.debug("Network error setting up Roborock: %s", err) | ||
| raise ConfigEntryNotReady( | ||
| translation_domain=DOMAIN, | ||
| translation_key="network_error", | ||
| ) from err | ||
|
|
||
| async def shutdown_roborock(_: Event | None = None) -> None: | ||
| await asyncio.gather(device_manager.close(), cache.flush()) |
Comment on lines
259
to
260
| @pytest.mark.parametrize("platforms", [[Platform.SENSOR]]) | ||
| async def test_stale_device( |
justanotherariel
approved these changes
Jun 1, 2026
justanotherariel
left a comment
justanotherariel
left a comment
Member
There was a problem hiding this comment.
Thanks @TheMerinoWolf
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed change
Bump
python-roborockfrom 5.12.0 to 5.14.1 and revert the defensiveaiohttp.ClientError/TimeoutErrorcatch added in #172492.The library v5.14.1 (via Python-roborock/python-roborock#835) now wraps network exceptions at the HTTP chokepoint (
PreparedRequest.request) so they emerge asRoborockException. The integration's existingexcept RoborockExceptionhandler inasync_setup_entryalready catches that and raisesConfigEntryNotReady. The HA-side defensive catch is now redundant and is reverted per @allenporter's review comment on #172492.Type of change
Additional information
Sequence:
Library diff: v5.12.0...v5.14.1
Checklist
ruff format homeassistant tests)If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running: `python3 -m script.hassfest`.
Updated by running `python3 -m script.gen_requirements_all`.