Feature/icloud media browser#162001
Open
timlaing wants to merge 23 commits into
Open
Conversation
Contributor
|
Hey there @Quentame, @nzapponi, mind taking a look at this pull request as it has been labeled with an integration ( Code owner commandsCode owners of
|
8 tasks
Contributor
There was a problem hiding this comment.
Pull request overview
Adds a new media source for the iCloud integration that exposes iCloud photo albums (including shared streams) as browsable and playable media, along with the necessary HTTP endpoint and tests.
Changes:
- Introduces
IcloudMediaSourceand related helpers to browse iCloud accounts, album types (albums vs shared streams), individual albums, and their photos/videos. - Adds
IcloudMediaSourceViewHTTP view to stream original and thumbnail media from iCloud with a simple in-memoryPhotoCacheto avoid repeated asset lookups. - Wires the media source into the iCloud integration setup and declares the
httpdependency, plus a comprehensive new test suite for the media source functionality.
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
homeassistant/components/icloud/media_source.py |
Implements the iCloud media source, identifier parsing, photo caching, album/photo browsing helpers, and the HTTP view that proxies media from iCloud. |
homeassistant/components/icloud/__init__.py |
Hooks media source setup into the integration’s top-level async_setup so the HTTP view and media source are registered when the integration is set up. |
homeassistant/components/icloud/manifest.json |
Adds the http dependency to ensure the HTTP component is available before registering the media source view. |
tests/components/icloud/test_media_source.py |
Adds extensive tests covering identifier parsing, cache behavior, album/photo browsing, media resolution, and HTTP view behavior (including response headers and timeout handling). |
tr4nt0r
suggested changes
Feb 3, 2026
joostlek
reviewed
Jun 9, 2026
joostlek
left a comment
Member
There was a problem hiding this comment.
Other than this I think this looks good
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed change
Added support for a media source based on iCloud albums.
Type of change
Additional information
Checklist
ruff format homeassistant tests)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest.requirements_all.txt.Updated by running
python3 -m script.gen_requirements_all.To help with the load of incoming pull requests: