feat: eip-5792 batch org creation + expand-role-to-circle#47
Merged
Conversation
Slim MeetingComponentsFactory.deploy to (subname, orgFactory) — resolves roleRegistry/govToken internally via getOrganizationBySubname, enabling race-free batching with createOrganization via wallet_sendCalls. Add useSendTransaction.sendBatch (EIP-5792 with sequential fallback) and wire useDeployOrganization to batch org + meeting components in one prompt. Add ExpandRoleToCircle (ChangeType 12) to HolacracyTypes, bool isCircle to Role struct, expandToCircle on RoleRegistry, and the MeetingFactory dispatch branch. Wire encoder + UI option in GovernanceMeetingRoom. Tests: 95/95 Foundry, 46/46 vitest, E2E Journey 6 (governance lifecycle). Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
…ory) ABI Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
MeetingComponentsFactory.deployslimmed to(subname, orgFactory)— resolves roleRegistry/govToken internally viagetOrganizationBySubname, eliminating the orgId prediction race. NewuseSendTransaction.sendBatchtrieswallet_sendCalls, falls back to sequential.useDeployOrganizationnow batchescreateOrganization+meetingComponentsFactory.deployin one wallet prompt.ChangeType.ExpandRoleToCircle(12) +bool isCircleon Role struct +RoleRegistry.expandToCircle(roleId)+ MeetingFactory dispatch branch. Wired in the UI as "Expand role to circle" option in the governance proposal wizard.Test plan
forge test)pnpm vitest run)turbo run check-types)pnpm --filter hola-modern test:e2eagainst local Anvil🤖 Generated with Claude Code