Call two seq() explicitly as Rcpp::seq()#9
Open
eddelbuettel wants to merge 1 commit into
Open
Conversation
9 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Dear Søren, dear gR* team,
Eigen 3.4.0 was released earlier in the year, and I have been asked to update RcppEigen to it. As documented in this issue at its GitHub repo, there are about 10 packages that built at CRAN under the previous release, but not with the Eigen 3.4.0 changes in the release candidate package -- which can be installed via
For
gRbase, the change is fairly simple. Apparently Eigen 3.4.0 confuses anotherseq()declaration so we (in just two places) needRcpp::seq(). With that simple changes in this PR, the package installs for me.It would be helpful for RcppEigen if you could apply the patch and release an updated version so that RcppEigen could be upgraded to a version with Eigen 3.4.0.
Let me know if you have any question, and please do not hesitate to reply and ask.
Cheers, Dirk (who looks after RcppEigen as a care-taker...)