Fix: use minimal_triang() in mpd.default() to ensure correct decomposition (#12)#13
Closed
Balance-H wants to merge 2 commits into
Closed
Fix: use minimal_triang() in mpd.default() to ensure correct decomposition (#12)#13Balance-H wants to merge 2 commits into
Balance-H wants to merge 2 commits into
Conversation
Author
|
Sorry, I accidentally deleted my fork repository which caused this PR to close. I have recreated the fix in a new PR #14. Please check that one instead. Apologies for the confusion! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi Søren,
I have implemented the fix discussed in Issue #12.
The current mpd.default() uses triangulate() which can add redundant chords, potentially leading to incorrect prime subgraph merges. By switching to minimal_triang(), we ensure the decomposition remains mathematically sound for non-chordal graphs.
This change has been tested against the example provided in #12 and yields the correct decomposition.