fix: fix flaky test in org.apache.helix.rest.server.TestResourceAccessor

[hofi1]

Issues

• My PR addresses the following Helix issues and references them in the PR description:

Fixes apache#2643

Description

This fix changes the flaky assertions of the tests in the class org.apache.helix.rest.server.TestResourceAccessor.
Sets return the elements in a non-deterministic order which means that this assertion is not correct, because it checks whether the collections contain the same elements in the same order. (This was changed in the library.)This leads to a flaky test. To fix this problem, the assertion has been rewritten to check if the collections contain the same amount of elements as well as both collections contain all values of the other collection.

The flaky test has been found by using the NonDex tool – to reproduce run

mvn -pl helix-rest edu.illinois:nondex-maven-plugin:2.1.1:nondex -Dtest=org.apache.helix.rest.server.TestResourceAccessor

Tests

There have been no tests added, one test condition was changed.

• The following is the result of the "mvn test" command on the appropriate module:

[INFO] ------------------------------------------------------------------------
[INFO] BUILD SUCCESS
[INFO] ------------------------------------------------------------------------
[INFO] Total time: 02:54 min
[INFO] Finished at: 2023-10-04T22:44:58-05:00

[deekshacheruku]

The fix looks good to me. But I guess you can add few more details to the PR description like linking which test is fixed and may be images. Good Work!

[219sansim]

General comments on your PR description summary-

1. Spelling error for 'flaky' - 'flack'
2. Give more context about NonDex tool and flaky tests in general
3. Point the developers to relevant resources (java docs) to understand that HashMap order is not guaranteed.
4. Explain that AssertEquals checks ordering as well
5. I don't think you would need to include 'mvn test' command output as the developers would have automated pipelines to check it.

[hofi1]

@219sansim thanks for the great feedback!
the mvn test command output is required by the owner of the repo

[219sansim]

LGTM

[zzjas]

You can consider if it makes sense to combine some of your PRs for helix into a larger one.

You can proceed to open a real PR. Once you open a real PR, please mark this tentative PR as Opened in your tentative_pr.csv file and also raise a PR to IDoFT marking this as Opened. Thanks!