chore: local dev HTTPS on :5180 + major dep bumps#20
Merged
Conversation
AppHost pins Web to https:5180 (WithHttpsEndpoint) and the realm import updates redirectUris + webOrigins to match. Keycloak stays on HTTP 8080 for the local Aspire dev loop. Existing KC data volume must be cleared (or the realm reimported) so the new client URIs take effect. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
Majors: Microsoft.ApplicationInsights.AspNetCore 2.23 -> 3.1.2, Octokit 13 -> 14, xunit.v3 1.1.0 -> 3.2.2, Microsoft.NET.Test.Sdk 17.13 -> 18.6.0, coverlet.collector 6.0.4 -> 10.0.1. Minors: Azure.Identity 1.14 -> 1.21, Scalar.AspNetCore 2.6 -> 2.14.14, System.IdentityModel.Tokens.Jwt 8.3 -> 8.18, xunit.runner.visualstudio 3.0.2 -> 3.1.5. Aspire.Hosting.Keycloak preview rolled to 13.3.5-preview.1.26270.6 (matches the stable 13.3.5 core line). No source changes required: existing AddApplicationInsightsTelemetry() and Octokit GitHubClient ctor surfaces are unchanged at the new majors, and xunit.v3's public test API stayed stable across the 1.x -> 3.x jump. JsonSchema.Net stays pinned at 7.* deliberately; bumping to 9.x reshapes EvaluationResults and needs a JsonSchemaValidator rewrite, tracked as a separate follow-up. Verified: dotnet build (Release) + dotnet test green (226 pass, 22 skipped — live-LLM + browser E2E skips). Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
5 tasks
hoangsnowy
added a commit
that referenced
this pull request
May 30, 2026
The Aspire dashboard mixed schemes — Web was HTTPS (:5180, PR #20) while the API still showed http://localhost:5080. Flip the API to HTTPS too so every .NET app endpoint in the AppHost is HTTPS and the documented links match. - src/AgentOs.Api/Properties/launchSettings.json: rename the launch profile http -> https, applicationUrl https://localhost:5080. Aspire reads the profile, so the api resource now exposes an HTTPS endpoint and the dashboard link is https://localhost:5080/scalar/v1. Uses the same ASP.NET dev cert as Web (dotnet dev-certs https --trust). - Docs (README, docs/SETUP.md, CLAUDE.md): update the Scalar / health / openapi / curl example URLs to https. - Code defaults that point at the local API follow it to https so they aren't broken-by-default against an https-only API: RemoteAgent REMOTE_AGENT_HUB default and the HttpPipelineClient Api:BaseUrl fallback. Both remain environment-overridable. Keycloak (:8080) and MailHog (:8025) intentionally stay HTTP — see the PR description. On localhost, putting KC behind a self-signed HTTPS cert breaks the backend OIDC metadata fetch (HttpClient rejects the untrusted cert) for zero security benefit; MailHog has no native TLS. Build clean. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
3 tasks
hoangsnowy
added a commit
that referenced
this pull request
May 30, 2026
…cy (#23) The Aspire dashboard mixed schemes — Web was HTTPS (:5180, PR #20) while the API still showed http://localhost:5080. Flip the API to HTTPS too so every .NET app endpoint in the AppHost is HTTPS and the documented links match. - src/AgentOs.Api/Properties/launchSettings.json: rename the launch profile http -> https, applicationUrl https://localhost:5080. Aspire reads the profile, so the api resource now exposes an HTTPS endpoint and the dashboard link is https://localhost:5080/scalar/v1. Uses the same ASP.NET dev cert as Web (dotnet dev-certs https --trust). - Docs (README, docs/SETUP.md, CLAUDE.md): update the Scalar / health / openapi / curl example URLs to https. - Code defaults that point at the local API follow it to https so they aren't broken-by-default against an https-only API: RemoteAgent REMOTE_AGENT_HUB default and the HttpPipelineClient Api:BaseUrl fallback. Both remain environment-overridable. Keycloak (:8080) and MailHog (:8025) intentionally stay HTTP — see the PR description. On localhost, putting KC behind a self-signed HTTPS cert breaks the backend OIDC metadata fetch (HttpClient rejects the untrusted cert) for zero security benefit; MailHog has no native TLS. Build clean. Co-authored-by: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
WithHttpsEndpoint, realm importredirectUris+webOriginsupdated; KC stays HTTP 8080).Decisions
7.*. Bumping to 9.x reshapesEvaluationResultsand needs aJsonSchemaValidatorrewrite — separate follow-up.Local-dev follow-up (after merge)
dotnet dev-certs https --trustif not already trusted.redirectUrisapply (realm import only fires on a fresh volume).Test plan
dotnet build AgentOs.slnx -c Releasecleandotnet test AgentOs.slnx -c Release→ 226 passed, 22 skipped (live-LLM + browser E2E)dotnet run --project infra/AgentOs.AppHost→ Web on https://localhost:5180, sign-in round-trip works🤖 Generated with Claude Code