[PIL-2900] Data entry hint text and error messages for new accounting period#666
Open
olakunlekuye2 wants to merge 13 commits into
Open
[PIL-2900] Data entry hint text and error messages for new accounting period#666olakunlekuye2 wants to merge 13 commits into
olakunlekuye2 wants to merge 13 commits into
Conversation
- Enforce Pillar 2 minimum before ETMP start boundary (combined constraint) - Update minimum error copy to on or after 31 December 2023 - Branch start/end hint messages for boundary vs pre-Pillar period examples - End hint copy references submitted period start when bounded
…conf Required to exercise the new accounting period amend journey in development.
|
Matches FrontendAppConfigSpec and repo default; local runs can override via application-local.conf if needed.
Replace invalid `view(...)` calls with `organisationView(...)` in the pre-Pillar hint scenario so test compilation succeeds in CI.
kevincoatsworth
previously approved these changes
Apr 14, 2026
Add view and form specs for Fran hint/error scenarios covering no-boundary, submitted-period boundary, and pre-Pillar precedence cases to lock expected hint text and minimum-date validation behavior.
…ar examples Update ChosenAccountingPeriod hint logic, messages, DateTimeUtils formatting, and NewAccountingPeriodViewSpec expectations.
Align hint and boundary validation copy with review: show the actual minimum start date and use on or after wording consistently.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Implements PIL-2900: correct hint text and validation on What is the group's new accounting period? (accounting period change).
Changes
pillar2MinimumThenOptionalStartBoundary).deriveNewAccountingPeriodDateBoundariessets minimum start from end of non-amendable period + 1 day (not period start).ChosenAccountingPeriodexposesstartDateHint/endDateHint; newmessages.enkeys for each branch (pre-Pillar periods, after submitted end, end before next submitted start, etc.).