change to just a space if highlight is empty

[hannah38]

Jira link

DTSPO-22071

Change description

Tested locally
Removes the text - but has a character to keep Slack happy if Highlight is not generated

Testing done

Checklist

• commit messages are meaningful and follow good commit message guidelines
• README and other documentation has been updated / added (if needed)
• tests have been updated / new tests has been added (if needed)
• Does this PR introduce a breaking change

[hmcts-platform-operations]

Plan Result (cftptl - Job)

No changes. Your infrastructure matches the configuration.

[timja]

something like this would be what I was trying to explain yesterday

Suggested change

	return convertHighlightToSlackMarkup(item.captions[0].highlights) || " ";
	const highlights = item.captions[0].highlights
	if (highlights?.length > 0) {
	return highlights
	}
	if (item?.captions[0]?.text?.length > 0) {
	return item.captions[0].text
	}
	// fallback to returning a single space if nothing else, (slack won't allow an empty block here)
	// TODO refactor so that the block isn't added if empty
	return " ";

concisely this may work as well but i'm not 100% sure on it:

Suggested change

	return convertHighlightToSlackMarkup(item.captions[0].highlights) || " ";
	return convertHighlightToSlackMarkup(item.captions[0].highlights) || item.captions[0].text || " ";