pofcc-131-recreate-from-srt - #5327
Open
anthonydummer wants to merge 5 commits into
Open
Conversation
* pofcc-131 initial check in * pofcc-131 adding checkRoleIsSupported to hmcts-global-header.component.ts * pofcc-131 linting issues and removal of temp test code. * pofcc-131 - yarn-audit-known-issues * pofcc-131 fixing issues on playwright tests * pofcc-131 - incorporated changes into master post srt * updating unit tests * spec changes * fix to funtional tests * Updating routing with tidier call to WAVerificationService * Adding hmcts-admin to the My work caseworker tab. * yarn-audit-known-issues * Adding PCS to preview build * name tweaks * yarn-audit-known-issues * lint issue * pofcc-131 adding in call to app.config * lint fixes * removing redundant wa- config. * Adding in the am roles to the search and find case menu items. * Adding in more hmcts- roles. * Updating base config * yarn-audit-known-issues * Update to global search to remove unnecessary am roles * remove caseworker-befta_master from prod set up. * lint fix * removing as per review comment * adding in old idam roles for functional test * Removing idam users from aat-diffs.ts * yarn-audit-known-issues * fix: support AM role backed navigation * test: stabilise api pack for dynamic aat data * test: harden AM menu role mock contract * test: align integration mocks with AM menu roles * User pre-release tk * fix api test --------- Co-authored-by: Andrew Grizhenkov <andrew.grizhenkov@hmcts.net> Co-authored-by: Josh <josh.glasgow@hmcts.net>
Josh-HMCTS
approved these changes
Jul 27, 2026
connorpgpmcelroy
requested changes
Jul 30, 2026
connorpgpmcelroy
left a comment
connorpgpmcelroy
left a comment
Contributor
There was a problem hiding this comment.
Minor changes needed.
Looks OK to me, only issue I can foresee is if there are different expectations for roles across services but don't think that'll be a problem
| FEATURE_ACCESS_MANAGEMENT_ENABLED: true | ||
| JURISDICTIONS: DIVORCE,PROBATE,FR,PUBLICLAW,IA,SSCS,EMPLOYMENT,CIVIL,CMC,HRS,PRIVATELAW,WA,PRL,BEFTA_JURISDICTION_1,BEFTA_JURISDICTION_2,BEFTA_JURISDICTION_3,ADOPTION,BEFTA_MASTER,DISPOSER_MASTER,ST_CIC,PCS,PT | ||
| GLOBAL_SEARCH_SERVICES: IA,CIVIL,PRIVATELAW,PUBLICLAW,EMPLOYMENT,ST_CIC,PCS | ||
| WA_SUPPORTED_JURISDICTIONS: IA,CIVIL,PRIVATELAW,PUBLICLAW,EMPLOYMENT,ST_CIC,PCS |
Contributor
There was a problem hiding this comment.
Minor concern - Do we need this? Would have thought it would be unnecessary and don't want to have to increase the number of places this config needs changing for no reason
| import { NavigationItem, UserNavModel } from '../../models'; | ||
| import { LoggerService } from '../../services/logger/logger.service'; | ||
| import { UserService } from '../../services/user/user.service'; | ||
| import { AppConstants } from 'src/app/app.constants'; |
Contributor
There was a problem hiding this comment.
Know it's not your change but shouldn't have src in here, do you mind changing please?
| type ConfigValue = string | boolean | Array<string> | object; | ||
| type WAConfig = { | ||
| wa_supported_role_categories?: unknown; | ||
| wa_supported_role_types?: unknown; |
Contributor
There was a problem hiding this comment.
Based on above should types not be string[]?
Contributor
There was a problem hiding this comment.
If added unknown because of Angular error, you're welcome to ignore this comment
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Jira link
https://tools.hmcts.net/jira/browse/POFCC-131
Change description
Created a new function to be called when checking config roles for compliance. If an AM roles matches a user role, further checks are made to ensure the role is a supported role.
Dependency PRs
hmcts/ccd-case-ui-toolkit#2231
Testing done
This pr is based on master with the addition of the commit used in the creation of the srt branch.
Security Vulnerability Assessment
CVE Suppression: Are there any CVEs present in the codebase (either newly introduced or pre-existing) that are being intentionally suppressed or ignored by this commit?
Checklist