EXUI-4758 - Add changes to allow multiple role categories - #548
EXUI-4758 - Add changes to allow multiple role categories#548connorpgpmcelroy wants to merge 4 commits into
Conversation
| } | ||
|
|
||
| // Note: Domain only used internally to set the PersonRole for the Person object | ||
| private setDomain(caseworker: Caseworker): PersonRole { |
There was a problem hiding this comment.
| private setDomain(caseworker: Caseworker): PersonRole { | |
| private getPersonRole(roleCategories: RoleCategory[]): PersonRole { |
There was a problem hiding this comment.
For now I'll leave it because domain is still the term used in other parts of common-lib and this is shortly to enter QA
|
|
||
| // Note: Domain only used internally to set the PersonRole for the Person object | ||
| private setDomain(caseworker: Caseworker): PersonRole { | ||
| if (caseworker.roleCategories.includes(RoleCategory.ADMIN)) { |
There was a problem hiding this comment.
this is changing the result as well as just extracting from the list, is that expected?
There was a problem hiding this comment.
You mean giving one role category, it's not really that important because this data field of 'domain' is not currently used anywhere - it just gives that roleCategory value to the objects to give more information about the data
There was a problem hiding this comment.
I mean that before this change, PersonRole could either be legal ops or admin. Now it can be admin, ctsc or legal ops (in that order). If that doesn't affect anything then that's fine, but why change it?
4 participants
Resolves #https://tools.hmcts.net/jira/browse/EXUI-4758
Notes: