Conversation
iamfrankiemoran
requested changes
Jul 9, 2026
Contributor
There was a problem hiding this comment.
[P2] Add retry context to minor creditor history reads
This PR opts safe OpalFines GETs into withHttpRetry, including the defendant history request, but the analogous minor creditor history request still builds plain { observe: 'response' } options. A transient 408/504 on the minor creditor History and notes tab will still go straight to the error path while the defendant tab retries; build these options with withRetrySafeReadOptions too.
louisbriggs
reviewed
Jul 10, 2026
| private readonly PARAM_ACCOUNT_STATUS_DATE_TO = 'account_status_date_to'; | ||
|
|
||
| private retrySafeReadOptions() { | ||
| return { context: withHttpRetry({ retryCount: 1, delayMs: 0 }) }; |
Contributor
There was a problem hiding this comment.
Should this config, passed to withHttpRetry, be stored in a const?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Jira link
See PO-3937
Change description
Upgrades @hmcts/opal-frontend-common to 0.0.90
Registers the shared httpRetryInterceptor in app.config.ts
Opts safe OpalFines read requests into retry using the common UI retry context helper
Keeps mutations and If-Match versioned requests out of retry
Testing done
Covered new functionality with unit tests
Security Vulnerability Assessment
CVE Suppression: Are there any CVEs present in the codebase (either newly introduced or pre-existing) that are being intentionally suppressed or ignored by this commit?
Checklist