FACT-2610 Counter service#303
Open
Ibrahimelsanosi-moj wants to merge 9 commits into
Open
Conversation
Contributor
Plan Result (aat)
|
Contributor
Plan Result (prod)
|
Ibrahimelsanosi-moj
changed the title
| extends JpaRepository<CourtCounterServiceOpeningHours, UUID> { | ||
|
|
||
| Optional<CourtCounterServiceOpeningHours> findByCourtId(UUID courtId); | ||
| Optional<List<CourtCounterServiceOpeningHours>> findByCourtId(UUID courtId); |
Contributor
There was a problem hiding this comment.
The standard contract for Spring Data is that list queries typically return List rather than Optional<List> as it can complicate semantics. In any case where there are no results JPA/Spring Data will alway return an empty list.
In our other repositories we either return a List<T> or a Page<T> when returning multiple results, so we should change this to conform.
| when(courtCounterServiceOpeningHoursRepository.findByCourtIdAndId(courtId, counterServiceOpeningHours.getId())) | ||
| .thenReturn(Optional.empty()); | ||
|
|
||
| assertThrows( |
Contributor
There was a problem hiding this comment.
We have a few of these in the code, but if you want to get shot of the sonar warning, I think you just need to move the counterServiceOpeningHours.getId() call outside of the lambda. I think the complaint is that from a purist perspective, that could potentially throw an NPE.
| } | ||
|
|
||
| @Test | ||
| void getCounterServiceOpeningHoursThrowsExceptionWhenNotFound() { |
Contributor
There was a problem hiding this comment.
Complete nitpick here, and might be wrong, but I think the naming convention in the file suggests that this method should be called getCounterServiceOpeningHoursByIdThrowsExceptionWhenNotFound
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
JIRA link
https://tools.hmcts.net/jira/browse/FACT-2610
Change description
Implement Counter service - admin for new FaCT
Does this PR require manual testing? (check one with "x")
Does this PR introduce a breaking change? (check one with "x")