FACT-2674 - being edited by (court locking)#299
Open
hurricanepilot wants to merge 18 commits into
Open
Conversation
- Introduced Lock and LockService to replace CourtLock and CourtLockService. - Updated database schema to generalize locks for both courts and service centres. - Added LockCleanupCheck and LockTimeoutCheck annotations for method-level lock management. - Refactored controller and service methods to accommodate new lock structure. - Updated tests to reflect changes in lock handling and naming conventions.
debolina-seal
requested changes
Jul 8, 2026
debolina-seal
previously approved these changes
Jul 9, 2026
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
JIRA link
FACT-2674
Change description
CourtLockwithLock(subjectType + subjectId) which supports bothCOURTandSERVICE_CENTRECourtLockController/CourtLockService/CourtLockRepositorytoLockController/LockService/LockRepositoryCOURT,COURT_ACCESSIBILITY, etc.) with broader page set (GENERAL,ADDRESS,ACCESSIBILITY,PHOTO, etc.)AuditSubjectTypeto sharedSubjectTypeand updated audit entity, controller, service, repository, and tests accordingly./courts/{courtId}/v1/locks...to/locks/{subjectType}/{subjectId}/v1...@LockTimeoutCheck(conflict vs stale lock expiry logic)@LockCleanupCheck(proactive cleanup of expired locks before reads)Does this PR require manual testing? (check one with "x")
Does this PR introduce a breaking change? (check one with "x")