FACT-2674 - being edited by (locking)#210
Open
hurricanepilot wants to merge 20 commits into
Open
Conversation
hurricanepilot
changed the title
In some cases, such as entering an invalid or made up UUID for a court or service centre, simply stopping the navigation dead in the locking interceptor may not be what we're after. In any case where the destination page should be expected to deal with problems, the locking interceptor will simply clear locks for the current user and let the destination page decide what to do with any errors.
…in-frontend into FACT-2674-being-edited-by
Contributor
Plan Result (aat)
Change Result (Click me) # azurerm_key_vault_secret.redis_v6_host will be updated in-place
~ resource "azurerm_key_vault_secret" "redis_v6_host" {
~ expiration_date = "2028-07-08T10:21:25Z" -> (known after apply)
id = "https://fact-kv-aat.vault.azure.net/secrets/REDIS-V6-HOST/aa3512d89cfb481eb216817ef98b93d3"
name = "REDIS-V6-HOST"
tags = {
"application" = "find-a-court-or-tribunal"
"autoShutdown" = "true"
"builtFrom" = "https://github.com/HMCTS/fact-admin-frontend.git"
"businessArea" = "CFT"
"contactSlackChannel" = "#fact-tech"
"environment" = "staging"
"managedBy" = "Find a Court or Tribunal"
"source" = "Redis"
}
# (10 unchanged attributes hidden)
}
# azurerm_key_vault_secret.redis_v6_password will be updated in-place
~ resource "azurerm_key_vault_secret" "redis_v6_password" {
~ expiration_date = "2028-07-08T10:21:25Z" -> (known after apply)
id = "https://fact-kv-aat.vault.azure.net/secrets/REDIS-V6-PASSWORD/2af05537b33242eaa3d2db124db84b95"
name = "REDIS-V6-PASSWORD"
tags = {
"application" = "find-a-court-or-tribunal"
"autoShutdown" = "true"
"builtFrom" = "https://github.com/HMCTS/fact-admin-frontend.git"
"businessArea" = "CFT"
"contactSlackChannel" = "#fact-tech"
"environment" = "staging"
"managedBy" = "Find a Court or Tribunal"
"source" = "Redis"
}
# (10 unchanged attributes hidden)
}
# azurerm_key_vault_secret.redis_v6_port will be updated in-place
~ resource "azurerm_key_vault_secret" "redis_v6_port" {
~ expiration_date = "2028-07-08T10:21:25Z" -> (known after apply)
id = "https://fact-kv-aat.vault.azure.net/secrets/REDIS-V6-PORT/12961eddb4814d47afc064347d5e9157"
name = "REDIS-V6-PORT"
tags = {
"application" = "find-a-court-or-tribunal"
"autoShutdown" = "true"
"builtFrom" = "https://github.com/HMCTS/fact-admin-frontend.git"
"businessArea" = "CFT"
"contactSlackChannel" = "#fact-tech"
"environment" = "staging"
"managedBy" = "Find a Court or Tribunal"
"source" = "Redis"
}
# (10 unchanged attributes hidden)
}
# module.redis-v6.azurerm_redis_cache.redis will be updated in-place
~ resource "azurerm_redis_cache" "redis" {
id = "/subscriptions/1c4f0704-a29e-403d-b719-b90c34ef14c9/resourceGroups/fact-admin-frontend-cache-aat/providers/Microsoft.Cache/redis/fact-admin-frontend-aat"
name = "fact-admin-frontend-aat"
tags = {
"application" = "find-a-court-or-tribunal"
"autoShutdown" = "true"
"builtFrom" = "https://github.com/HMCTS/fact-admin-frontend.git"
"businessArea" = "CFT"
"contactSlackChannel" = "#fact-tech"
"environment" = "staging"
"managedBy" = "Find a Court or Tribunal"
}
# (24 unchanged attributes hidden)
~ redis_configuration {
~ maxfragmentationmemory_reserved = 125 -> 200
~ maxmemory_delta = 125 -> 200
~ maxmemory_reserved = 125 -> 200
# (14 unchanged attributes hidden)
}
}
Plan: 0 to add, 4 to change, 0 to destroy. |
Contributor
Plan Result (prod)
Change Result (Click me) # azurerm_key_vault_secret.redis_v6_host will be updated in-place
~ resource "azurerm_key_vault_secret" "redis_v6_host" {
~ expiration_date = "2028-07-08T09:56:46Z" -> (known after apply)
id = "https://fact-kv-prod.vault.azure.net/secrets/REDIS-V6-HOST/7bdf3ae4e5be4715b31014dea8bf9875"
name = "REDIS-V6-HOST"
tags = {
"application" = "find-a-court-or-tribunal"
"builtFrom" = "https://github.com/HMCTS/fact-admin-frontend.git"
"businessArea" = "CFT"
"contactSlackChannel" = "#fact-tech"
"environment" = "production"
"managedBy" = "Find a Court or Tribunal"
"source" = "Redis"
}
# (10 unchanged attributes hidden)
}
# azurerm_key_vault_secret.redis_v6_password will be updated in-place
~ resource "azurerm_key_vault_secret" "redis_v6_password" {
~ expiration_date = "2028-07-08T09:56:46Z" -> (known after apply)
id = "https://fact-kv-prod.vault.azure.net/secrets/REDIS-V6-PASSWORD/ea2fb08677a844f3b6fad9d5b16a958e"
name = "REDIS-V6-PASSWORD"
tags = {
"application" = "find-a-court-or-tribunal"
"builtFrom" = "https://github.com/HMCTS/fact-admin-frontend.git"
"businessArea" = "CFT"
"contactSlackChannel" = "#fact-tech"
"environment" = "production"
"managedBy" = "Find a Court or Tribunal"
"source" = "Redis"
}
# (10 unchanged attributes hidden)
}
# azurerm_key_vault_secret.redis_v6_port will be updated in-place
~ resource "azurerm_key_vault_secret" "redis_v6_port" {
~ expiration_date = "2028-07-08T09:56:46Z" -> (known after apply)
id = "https://fact-kv-prod.vault.azure.net/secrets/REDIS-V6-PORT/0c8979c128ac4c0887876619416a53ab"
name = "REDIS-V6-PORT"
tags = {
"application" = "find-a-court-or-tribunal"
"builtFrom" = "https://github.com/HMCTS/fact-admin-frontend.git"
"businessArea" = "CFT"
"contactSlackChannel" = "#fact-tech"
"environment" = "production"
"managedBy" = "Find a Court or Tribunal"
"source" = "Redis"
}
# (10 unchanged attributes hidden)
}
Plan: 0 to add, 3 to change, 0 to destroy. |
josh-uk
reviewed
Jul 9, 2026
| alias: API_APP_REG_ID | ||
| environment: | ||
| DATA_API_URL: 'https://fact-data-api.{{ .Values.global.environment }}.platform.hmcts.net' | ||
| DATA_API_URL: 'https://fact-data-api-pr-299.preview.platform.hmcts.net/' |
Contributor
There was a problem hiding this comment.
remove before merge reminder
josh-uk
reviewed
Jul 9, 2026
|
|
||
| withPipeline(type, product, component) { | ||
| env.DATA_API_URL = 'https://fact-data-api.aat.platform.hmcts.net' | ||
| env.DATA_API_URL = 'https://fact-data-api-pr-299.preview.platform.hmcts.net/' |
Contributor
There was a problem hiding this comment.
remove before merge reminder
josh-uk
approved these changes
Jul 9, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
JIRA link
FACT-2674
Change description
Changes to the admin frontend to handle acquisition and management of page locks.
Does this PR require manual testing? (check one with "x")
Does this PR introduce a breaking change? (check one with "x")