feat: roleAssigned 通知に role 情報を含める#26
Merged
Merged
Conversation
Misskey の roleAssigned 通知に含まれる role (ロール情報) を RawNotification / NormalizedNotification に追加し、正規化で伝播する。 これまで捨てられていたためフロントでロール名を表示できなかった。 既存の specta 対応 UserRole 型を再利用。 Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
なぜ
hitalin/notedeck#687 — ロール割り当て通知 (
roleAssigned) でロール名が表示されない。原因は、Misskey の
roleAssigned通知に含まれるrole(ロール情報) が、RawNotification→NormalizedNotificationの正規化で捨てられていたため。フロント側にロール名が届いていなかった。変更
RawNotification/NormalizedNotificationにrole: Option<UserRole>を追加normalize()でroleを伝播UserRole型を再利用（id/name/color/iconUrl/description/displayOrder）roleAssigned通知パースのテストを追加テスト
→ 2 件 pass
🤖 Generated with Claude Code