Skip to content

Replace the calling of this pointer in public static function#87

Open
jialong-google wants to merge 1 commit into
hildjj:mainfrom
jialong-google:jialong-revision
Open

Replace the calling of this pointer in public static function#87
jialong-google wants to merge 1 commit into
hildjj:mainfrom
jialong-google:jialong-revision

Conversation

@jialong-google

Copy link
Copy Markdown

Replaced the calling of this pointer with class name reference instead to prevent run time err.

Replaced the calling of this pointer with class name reference instead to prevent run time err.
@codecov-commenter

Copy link
Copy Markdown

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (99b2139) to head (06eac82).

Additional details and impacted files
@@            Coverage Diff            @@
##              main       #87   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           18        18           
  Lines         4578      4578           
  Branches       632       632           
=========================================
  Hits          4578      4578           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@hildjj

hildjj commented Jun 28, 2025

Copy link
Copy Markdown
Owner

What sort of error does this cause?

@jialong-google

Copy link
Copy Markdown
Author

This would have an err"Uncaught TypeError: Cannot read properties of undefined (reading 'tags')" which caused my service worker registration failed.

@hildjj

hildjj commented Jan 20, 2026

Copy link
Copy Markdown
Owner

I've never seen this error, would love to know which runtime you're using. That said, I'm willing to take the patch.

Please add yourself to the contributors section in package.json.

@ikimonogakari

ikimonogakari commented May 6, 2026

Copy link
Copy Markdown

This mostly happens when this library is compiled to a old ES version by certain compilers, such as https://developers.google.com/closure/compiler

@hildjj

hildjj commented May 7, 2026

Copy link
Copy Markdown
Owner

Sounds like it might be an unsupported platform. I would like a reproduction before taking the change.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants