Replace the calling of this pointer in public static function#87
Replace the calling of this pointer in public static function#87jialong-google wants to merge 1 commit into
Conversation
Replaced the calling of this pointer with class name reference instead to prevent run time err.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #87 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 18 18
Lines 4578 4578
Branches 632 632
=========================================
Hits 4578 4578 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
What sort of error does this cause? |
|
This would have an err"Uncaught TypeError: Cannot read properties of undefined (reading 'tags')" which caused my service worker registration failed. |
|
I've never seen this error, would love to know which runtime you're using. That said, I'm willing to take the patch. Please add yourself to the |
|
This mostly happens when this library is compiled to a old ES version by certain compilers, such as https://developers.google.com/closure/compiler |
|
Sounds like it might be an unsupported platform. I would like a reproduction before taking the change. |
Replaced the calling of this pointer with class name reference instead to prevent run time err.