fix(event): isolate verified browsers behind shared NAT#148
Merged
hikariming merged 1 commit intoJul 20, 2026
Merged
Conversation
|
@AsperforMias is attempting to deploy a commit to the hikariming's projects Team on Vercel. A member of the Team first needs to authorize it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Context
At an event, many legitimate browser users can share one public IP. The previous scan and roast limits used that IP as the only identity, so one active participant could consume another participant's scan or default-model roast budget.
Change
/api/scansuccessfully verifies Turnstile, issue a 12-hour signed,HttpOnly,SameSite=Laxanonymous browser-session cookie.Scope
No score formula, release version, quick scan, LLM provider, durable work, worker, or Cron behavior changes.
Verification
pnpm exec vitest run src/lib/__tests__/anonymous-session.test.ts src/lib/__tests__/redis-rate-limit.test.ts src/app/api/scan/route.test.ts src/app/api/roast/route.test.tspnpm typecheckpnpm lintpnpm versions:check(v9/v9/v4canonical guard passed)pnpm test(67 files, 507 tests)pnpm buildRollout check
After deployment, use two separate browser profiles on the same network. Each should complete a Turnstile-backed scan and roast independently; machine-authenticated callers remain IP-limited. Production must retain its existing Turnstile server secret for the per-browser isolation path to activate.